move removal of external tflint flag back to tflint module

Author: thisguycodes

internal/runner/run/hook.go

@@ -182,11 +182,6 @@ func runHook(
 	containsExternalTFLintFlag := slices.Contains(curHook.Execute, tflint.TfExternalTFLint)
 	if actionToExecute == "tflint" {
 		if containsExternalTFLintFlag {
-			// delete the flag and run external tflint
-			curHook.Execute = slices.DeleteFunc(curHook.Execute, func(arg string) bool {
-				return arg == tflint.TfExternalTFLint
-			})
-
 			return executeTFLint(ctx, l, opts, cfg, curHook, workingDir, true)
 		} else {
 			strictControl := opts.StrictControls.Find(controls.InternalTFLint)

internal/tflint/tflint.go

@@ -6,6 +6,7 @@ import (
 	"context"
 	"fmt"
 	"path/filepath"
+	"slices"
 	"strings"
 
 	"github.com/gruntwork-io/terratest/modules/collections"
@@ -30,8 +31,13 @@ const (
 
 // RunTflintWithOpts runs tflint with the given options and returns an error if there are any issues.
 func RunTflintWithOpts(ctx context.Context, l log.Logger, opts *options.TerragruntOptions, cfg *runcfg.RunConfig, hook *runcfg.Hook, externalTfLint bool) error {
+	args := slices.Clone(hook.Execute)
+	args = slices.DeleteFunc(args, func(arg string) bool {
+		return arg == TfExternalTFLint
+	})
+
 	// try to fetch configuration file from hook parameters
-	configFile, err := tflintConfigFilePath(l, opts, hook.Execute)
+	configFile, err := tflintConfigFilePath(l, opts, args)
 	if err != nil {
 		return err
 	}
@@ -55,7 +61,7 @@ func RunTflintWithOpts(ctx context.Context, l log.Logger, opts *options.Terragru
 		return errors.New(err)
 	}
 
-	tflintArgs := hook.Execute[1:]
+	tflintArgs := args[1:]
 
 	// tflint init
 	initArgs := []string{"tflint", "--init", "--config", configFile, "--chdir", opts.WorkingDir}