tests update

Author: denis256

internal/remotestate/backend/gcs/config.go

@@ -56,6 +56,10 @@ func (cfg Config) ParseExtendedGCSConfig() (*ExtendedRemoteStateConfigGCS, error
 		extendedConfig ExtendedRemoteStateConfigGCS
 	)
 
+	// WeakDecode handles string->bool coercion ("true"/"false") needed when HCL ternary
+	// type unification produces string values for bool fields (see #5475). Also accepts
+	// strconv.ParseBool inputs ("1"/"0"/"t"/"f"). When adding new struct fields, verify
+	// that WeakDecode coercion behavior is acceptable for the field type.
 	if err := mapstructure.WeakDecode(cfg, &gcsConfig); err != nil {
 		return nil, errors.New(err)
 	}

internal/remotestate/backend/gcs/config_test.go

@@ -170,6 +170,28 @@ func TestParseExtendedGCSConfig_StringBoolCoercion(t *testing.T) {
 				assert.True(t, cfg.SkipBucketVersioning)
 			},
 		},
+		{
+			"empty-string-coerces-to-false",
+			gcs.Config{
+				"bucket":                 "my-bucket",
+				"skip_bucket_versioning": "",
+			},
+			func(t *testing.T, cfg *gcs.ExtendedRemoteStateConfigGCS) {
+				t.Helper()
+				assert.False(t, cfg.SkipBucketVersioning)
+			},
+		},
+		{
+			"numeric-one-coerces-to-true",
+			gcs.Config{
+				"bucket":                 "my-bucket",
+				"skip_bucket_versioning": "1",
+			},
+			func(t *testing.T, cfg *gcs.ExtendedRemoteStateConfigGCS) {
+				t.Helper()
+				assert.True(t, cfg.SkipBucketVersioning)
+			},
+		},
 	}
 
 	for _, tc := range testCases {

internal/remotestate/backend/s3/config.go

@@ -101,6 +101,10 @@ func (cfg Config) ParseExtendedS3Config() (*ExtendedRemoteStateConfigS3, error)
 		extendedConfig ExtendedRemoteStateConfigS3
 	)
 
+	// WeakDecode handles string->bool coercion ("true"/"false") needed when HCL ternary
+	// type unification produces string values for bool fields (see #5475). Also accepts
+	// strconv.ParseBool inputs ("1"/"0"/"t"/"f"). When adding new struct fields, verify
+	// that WeakDecode coercion behavior is acceptable for the field type.
 	if err := mapstructure.WeakDecode(cfg, &s3Config); err != nil {
 		return nil, errors.New(err)
 	}

internal/remotestate/backend/s3/config_test.go

@@ -98,6 +98,32 @@ func TestParseExtendedS3Config_StringBoolCoercion(t *testing.T) {
 				assert.True(t, cfg.RemoteStateConfigS3.UseLockfile)
 			},
 		},
+		{
+			"empty-string-coerces-to-false",
+			s3backend.Config{
+				"bucket":       "my-bucket",
+				"key":          "my-key",
+				"region":       "us-east-1",
+				"use_lockfile": "",
+			},
+			func(t *testing.T, cfg *s3backend.ExtendedRemoteStateConfigS3) {
+				t.Helper()
+				assert.False(t, cfg.RemoteStateConfigS3.UseLockfile)
+			},
+		},
+		{
+			"numeric-one-coerces-to-true",
+			s3backend.Config{
+				"bucket":       "my-bucket",
+				"key":          "my-key",
+				"region":       "us-east-1",
+				"use_lockfile": "1",
+			},
+			func(t *testing.T, cfg *s3backend.ExtendedRemoteStateConfigS3) {
+				t.Helper()
+				assert.True(t, cfg.RemoteStateConfigS3.UseLockfile)
+			},
+		},
 	}
 
 	for _, tc := range testCases {