operator- for time

[conversy]

shouldn't there be something like:

    if (ns<0) {
      ns += 1'000'000'000;
      s -= 1;
    }

in

static inline __gthread_time_t operator-(
      const __gthread_time_t &lhs, const timeval &rhs)

?

[grygorek]

Almost. I think it is more like..

  if (s > 0) {
    while (ns < 0) {
      ns += 1'000'000'000;
      s -= 1;
    }
  }

What about using chrono....

struct __gthread_time_t {
  long sec;
  long nsec;
  int64_t milliseconds() const {
    auto s = std::chrono::seconds(sec);
    auto ns = std::chrono::nanoseconds(nsec);
    return std::chrono::duration_cast<std::chrono::milliseconds>(s + ns).count();
  }
};

static inline __gthread_time_t operator-(const __gthread_time_t &lhs,
                                       const timeval &rhs) {
    using namespace std::chrono;

     auto l = seconds(lhs.sec) + nanoseconds(lhs.nsec);
     auto r = seconds(rhs.tv_sec) + microseconds(rhs.tv_usec);
     auto res = l - r;

     auto s = duration_cast<seconds>(res); 
     return {s.count(), duration_cast<nanoseconds>(res - s).count() };
}

What do you think?

I would prefer the second option. I am just not sure if using C++ in gthr-default.h is legal....
BTW, I am using C++ there through the includes anyway.