Skip to content

Commit 4c851ce

Browse files
committed
Refactors the slider to use setDesc instead of a tooltip
1 parent 0fd1fc4 commit 4c851ce

File tree

6 files changed

+22
-34
lines changed

6 files changed

+22
-34
lines changed

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"id": "varinote",
33
"name": "Varinote",
4-
"version": "1.1.0",
4+
"version": "1.1.1",
55
"minAppVersion": "1.7.7",
66
"description": "Add variables in templates and set their values on-the-fly during the note creation.",
77
"author": "Giorgos Sarigiannidis",

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "varinote",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"description": "Add variables in Templates and set their values on-the-fly during the Note creation.",
55
"main": "dist/main.js",
66
"scripts": {

src/fields/sliderField.ts

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -31,30 +31,19 @@ export function createSliderField(
3131
}
3232

3333
const sliderContainer = document.createElement('div');
34-
sliderContainer.style.position = 'relative';
3534
contentEl.appendChild(sliderContainer);
3635

37-
let currentTooltip: HTMLElement | null = null;
38-
39-
new Setting(sliderContainer)
36+
const setting = new Setting(sliderContainer)
4037
.setName(property.label)
38+
.setDesc(defaultValue.toString())
39+
.setClass('setting-item-slider')
4140
.addSlider(slider => {
42-
const inputEl = sliderContainer.querySelector('input[type="range"]');
43-
if (!inputEl) return;
44-
45-
currentTooltip = document.createElement('div');
46-
currentTooltip.className = 'slider-tooltip';
47-
currentTooltip.textContent = defaultValue.toString();
48-
sliderContainer.appendChild(currentTooltip);
49-
5041
return slider
5142
.setLimits(min, max, step)
5243
.setValue(defaultValue)
5344
.onChange((value: number) => {
5445
formValues[key] = value;
55-
if (currentTooltip) {
56-
currentTooltip.textContent = value.toString();
57-
}
46+
setting.setDesc(value.toString());
5847
});
5948
});
6049
}

styles.css

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,19 @@
1414
}
1515
}
1616

17-
.setting-item {
18-
&:has(.slider) {
19-
max-width: calc(100% - 2em);
17+
& .setting-item-slider {
18+
& .setting-item-name {
19+
display: inline;
2020
}
21-
}
2221

23-
& .slider-tooltip {
24-
position: absolute;
25-
display: block;
26-
padding-right: 0;
27-
left: unset;
28-
right: 0.2em;
29-
font-size: 0.9em;
30-
top: calc(50% - 1.1em);
31-
pointer-events: none;
22+
& .setting-item-description {
23+
display: inline-block;
24+
font-weight: bold;
25+
font-size: var(--font-ui-medium);
26+
&::before {
27+
content: ": ";
28+
font-weight: normal;
29+
}
30+
}
3231
}
33-
3432
}

versions.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
"1.0.8": "1.7.7",
1111
"1.0.9": "1.7.7",
1212
"1.0.10": "1.7.7",
13-
"1.1.0": "1.7.7"
13+
"1.1.0": "1.7.7",
14+
"1.1.1": "1.7.7"
1415
}

0 commit comments

Comments
 (0)