Merge branch 'isce-framework:develop' into develop

Author: gshiroma

python/packages/nisar/products/writers/BaseWriterSingleInput.py

@@ -663,10 +663,16 @@ def populate_identification_common(self):
             processing_type = np.bytes_('Nominal')
         elif processing_type_runconfig == 'UR':
             processing_type = np.bytes_('Urgent')
-        elif processing_type_runconfig == 'OD':
-            processing_type = np.bytes_('Custom')
         else:
-            processing_type = np.bytes_('Undefined')
+            if processing_type_runconfig != 'OD':
+                warning_channel = journal.warning(
+                    'BaseWriterSingleInput.populate_identification_common()')
+                warning_channel.log(
+                    'The processing type in the runconfig is set to'
+                    f' "{processing_type_runconfig}", which is not a valid value'
+                    ' for the output product metadata. Defaulting to "Custom"')
+            processing_type = np.bytes_('Custom')
+
         self.set_value(
             'identification/processingType',
             processing_type,

python/packages/nisar/products/writers/GcovWriter.py

@@ -813,16 +813,17 @@ def populate_processing_information_timing_corrections(self):
         Populate the `processingInformation/timingCorrections` group of the
         GCOV product
         """
-        timing_corrections_group_path = \
-            (self.output_product_path +
-             '/metadata/processingInformation/'
-             'timingCorrections')
 
         processing_information_geogrid = self.cfg['processing'][
             'processing_information']['geogrid']
 
         for frequency in self.input_freq_pols_dict.keys():
 
+            timing_corrections_group_path = \
+                (self.output_product_path +
+                 '/metadata/processingInformation/'
+                 f'timingCorrections/frequency{frequency}')
+
             if (self.timing_corrections_dict is not None and
                 frequency in
                     self.timing_corrections_dict['az_correction'].keys()):

share/nisar/defaults/gcov.yaml

@@ -201,7 +201,7 @@ runconfig:
                 # omitted from the output. If the input data does not contain
                 # HV and VH channels, then the "symmetrize_cross_pol_channels"
                 # flag will be ignored by the workflow.
-                symmetrize_cross_pol_channels:  True
+                symmetrize_cross_pol_channels:  False
 
             # NOT YET IMPLEMENTED - Only checked when internet access is available
             dem_download: