Updated README and install/update pages

gsingh93 · gsingh93 · commit c63661774bf6 · 2014-04-05T00:03:22.000-04:00
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 Regex Search
 ===============
 
-This is a chrome extension that allows you to search the text of any page using regular expressions.
+This is a chrome extension written in [TypeScript](http://www.typescriptlang.org/) that allows you to search the text of any page using regular expressions.
 
 You can download the extension here: https://chrome.google.com/webstore/detail/bcdabfmndggphffkchfdcekcokmbnkjl
 
@@ -19,3 +19,8 @@ Build guide
 ============
 1. Clone this repo and execute ```npm install``` inside the created directory, 
 2. Run ```grunt``` in order to build the extension (```build/``` is the output directory).
+
+Contributers
+============
+
+Thanks to [ComFreek](https://github.com/ComFreek) for converting a large portion of the code base to TypeScript.
diff --git a/src/background/KeyboardHandler.ts b/src/background/KeyboardHandler.ts
@@ -7,13 +7,13 @@ module KeyboardHandler {
     var lastCalled: number = 0;
 
     export function init(tabStates: TabStateManager) {
-        chrome.commands.onCommand.addListener(function (command: string) {
+        chrome.commands.onCommand.addListener(function(command: string) {
             Log.info("Received command " + command);
             Utils.withActiveTab(function(tab: chrome.tabs.Tab) {
                 var id = tab.id;
 
-                // The time hack is to get around this function being called twice when
-                // the popup is open
+                // The time hack is due to a bug in Chrome:
+                // https://code.google.com/p/chromium/issues/detail?id=355559
                 var d = new Date();
                 if (tabStates.exists(id) && tabStates.get(id, "searching")
                     && d.getTime() - lastCalled > 50) {
diff --git a/src/content/content.js b/src/content/content.js
@@ -240,7 +240,7 @@ function elementInViewport(el) {
         left += el.offsetLeft;
     }
 
-    return top >= window.pageYOffset && left >= window.pageXOffset
-        && (top + height) <= (window.pageYOffset + window.innerHeight)
-        && (left + width) <= (window.pageXOffset + window.innerWidth);
+    return top >= window.pageYOffset && left >= window.pageXOffset &&
+        (top + height) <= (window.pageYOffset + window.innerHeight) &&
+        (left + width) <= (window.pageXOffset + window.innerWidth);
 }
diff --git a/src/pages/install.html b/src/pages/install.html
@@ -4,7 +4,7 @@
     <title>Regex Search Updated</title>
   </head>
   <body>
-    <h1>Regex Search 1.6</h1>
+    <h1>Regex Search 1.7</h1>
     <b>How to use:</b>
     <ul>
         <li>Type in a regex query and click Next to search. Clicking Next again will go to the next match. Modifying the search query will clear the current search. Note that this extension will not work on the Chrome store, so do not test it on any Chrome store pages.</li>
@@ -14,7 +14,7 @@ <h1>Regex Search 1.6</h1>
         <li>You can open the extension by typing Alt+Shift+F. You can go to the next and previous search results by typing Alt+Shift+N and Alt+Shift+P, respectively. These shortcuts can be configured by going to the bottom of the extensions page and clicking "Keyboard Shortcuts"</li>
         <li>This extension uses the JavaScript regex engine. I create a regular expression using 'new RegExp(regexp, flags)', where flags are currently either 'g' or 'gi'.</li>
         <li>This extension is open source and the code can be found <a href="https://github.com/gsingh93/regex-search">here</a>. I'd appreciate any help, whether it's adding new features, fixing bugs, or making the extension look better (including this page).</li>
-        <li>If you find any bugs, let me know <a href="https://github.com/gsingh93/regex-search/issues">here</a>.
+        <li>If you find any bugs, let me know <a href="https://github.com/gsingh93/regex-search/issues">here</a>.</li>
         <li>If you like this extension, please review it in the <a href="https://chrome.google.com/webstore/detail/regex-search/bcdabfmndggphffkchfdcekcokmbnkjl/reviews">Chrome store</a></li>
     </ul>
     <b>Upcoming Features:</b>
diff --git a/src/pages/update.html b/src/pages/update.html
@@ -4,20 +4,19 @@
     <title>Regex Search Updated</title>
   </head>
   <body>
-    <h1>Regex Search 1.6</h1>
+    <h1>Regex Search 1.7</h1>
     <b>Updates:</b>
     <ul>
-        <li>Search and Clear buttons have been removed. Search with the Next button, and clear by modifying the regex.</li>
-        <li>Next button is greyed out when not applicable, just as requested.</li>
-        <li>Next and Prev buttons now wrap around.</li>
-        <li>You can open the extension by typing Alt+Shift+F. You can go to the next and previous search results by typing Alt+Shift+N and Alt+Shift+P, respectively. These shortcuts can be configured by going to the bottom of the extensions page and clicking "Keyboard Shortcuts"</li>
-        <li>You will now see "Searching..." in the upper right corner while a search is running so you know that the extension is working</li>
+        <li>Most of the code base has been converted to TypeScript with the help of <a href="https://github.com/ComFreek">ComFreek</a></li>
+        <li>Fixed a bug where search doesn't work when changing to a different page.</li>
+        <li>Added an options page where you can set whether you want case insensitive to be on or off by default.</li>
     </ul>
     <b>Notes:</b>
     <ul>
+        <li>You can open the extension by typing Alt+Shift+F. You can go to the next and previous search results by typing Alt+Shift+N and Alt+Shift+P, respectively. These shortcuts can be configured by going to the bottom of the extensions page and clicking "Keyboard Shortcuts"</li>
         <li>This extension uses the JavaScript regex engine. I create a regular expression using 'new RegExp(regexp, flags)', where flags are currently either 'g' or 'gi'.</li>
         <li>This extension is open source and the code can be found <a href="https://github.com/gsingh93/regex-search">here</a>. I'd appreciate any help, whether it's adding new features, fixing bugs, or making the extension look better (including this update page).</li>
-        <li>This update probably introduced a couple of bugs. If you find any, let me know <a href="https://github.com/gsingh93/regex-search/issues">here</a>.
+        <li>This update probably introduced a couple of bugs. If you find any, let me know <a href="https://github.com/gsingh93/regex-search/issues">here</a>.</li>
         <li>If you like this extension, please review it in the <a href="https://chrome.google.com/webstore/detail/regex-search/bcdabfmndggphffkchfdcekcokmbnkjl/reviews">Chrome store</a></li>
     </ul>
     <b>Upcoming Features:</b>

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ function elementInViewport(el) {`
`240`	`240`	`left += el.offsetLeft;`
`241`	`241`	`}`
`242`	`242`
`243`		`- return top >= window.pageYOffset && left >= window.pageXOffset`
`244`		`- && (top + height) <= (window.pageYOffset + window.innerHeight)`
`245`		`- && (left + width) <= (window.pageXOffset + window.innerWidth);`
	`243`	`+ return top >= window.pageYOffset && left >= window.pageXOffset &&`
	`244`	`+ (top + height) <= (window.pageYOffset + window.innerHeight) &&`
	`245`	`+ (left + width) <= (window.pageXOffset + window.innerWidth);`
`246`	`246`	`}`