Skip to content

Commit ac844a4

Browse files
committed
fix: remove continue-on-error so e2e test failures properly fail workflow
BREAKING FIX: E2E test failures now correctly fail the GitHub Action workflow. Previously, 'continue-on-error: true' was masking test failures, causing the workflow to show 'success' even when 14 out of 15 tests failed. Changes: - Removed 'continue-on-error: true' flag - Tests now properly fail the workflow when they fail - Added clear warning messages about expected LocalCluster/OTP 28 failures - Enhanced summary step to explain the known issue The workflow will now fail (as expected) until LocalCluster/OTP 28 compatibility issues are resolved upstream. This is more honest than silently passing failed tests. Current test status: 14/15 failures due to :peer module :not_alive error
1 parent e6dbf32 commit ac844a4

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

.github/workflows/e2e-test.yml

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,15 @@ jobs:
5959

6060
- name: Run E2E Distributed Tests
6161
run: |
62-
echo "Running e2e distributed tests..."
62+
echo "⚠️ WARNING: E2E tests currently fail due to LocalCluster/OTP 28 compatibility"
63+
echo "The :peer module times out when starting child nodes in OTP 28"
64+
echo "See e2e_test/README.md for manual testing instructions"
65+
echo ""
66+
echo "Running tests to document current failure state..."
67+
echo ""
6368
MIX_ENV=e2e_test mix test e2e_test/distributed/ --trace --max-cases 1
6469
env:
6570
MIX_ENV: e2e_test
66-
continue-on-error: true
6771

6872
- name: Upload test results
6973
if: failure()
@@ -139,9 +143,19 @@ jobs:
139143
- name: Check test results
140144
run: |
141145
echo "E2E Distributed Tests: ${{ needs.e2e-distributed.result }}"
146+
echo ""
142147
if [ "${{ needs.e2e-distributed.result }}" != "success" ]; then
143148
echo "❌ E2E distributed tests failed"
149+
echo ""
150+
echo "NOTE: Tests are expected to fail due to LocalCluster/OTP 28 compatibility issues"
151+
echo "The :peer module (used by LocalCluster 2.x) times out when starting child nodes"
152+
echo ""
153+
echo "Workaround: Use manual multi-node testing"
154+
echo "See: e2e_test/README.md for instructions"
155+
echo ""
156+
echo "This is a known upstream issue being tracked."
144157
exit 1
145158
else
146159
echo "✅ E2E distributed tests passed"
160+
echo "The LocalCluster/OTP 28 compatibility issue appears to be resolved!"
147161
fi

0 commit comments

Comments
 (0)