fix: use shell script wrapper in e2e workflow and safer cleanup pattern

- Update e2e-test.yml to use ./scripts/run_e2e_tests.sh wrapper
- Use more specific pkill pattern (concord_e2e[0-9]+@) to avoid killing test runner
- Safer cleanup that only targets node processes, not the test runner

Author: GSMLG-BOT

.github/workflows/e2e-test.yml

@@ -60,7 +60,7 @@ jobs:
       - name: Run E2E Distributed Tests
         run: |
           echo "Running e2e distributed tests with manual node spawning..."
-          MIX_ENV=e2e_test elixir --name test@127.0.0.1 --cookie concord_e2e_test -S mix test e2e_test/distributed/ --trace
+          ./scripts/run_e2e_tests.sh e2e_test/distributed/
         env:
           MIX_ENV: e2e_test
 

e2e_test/support/e2e_cluster_helper.ex

@@ -143,8 +143,8 @@ defmodule Concord.E2E.ClusterHelper do
     # Give time for graceful shutdown
     Process.sleep(500)
 
-    # Force kill any remaining processes
-    System.cmd("pkill", ["-9", "-f", "concord_e2e"], stderr_to_stdout: true)
+    # Force kill any remaining node processes (use specific pattern)
+    System.cmd("pkill", ["-9", "-f", "concord_e2e[0-9]+@"], stderr_to_stdout: true)
 
     # Clean up data directories
     cleanup_data_dirs()

e2e_test/test_helper.exs

@@ -1,8 +1,10 @@
 # Clean up orphan processes from previous runs
+# Only kill node processes, not the test runner
 defmodule Concord.E2E.Cleanup do
   def kill_orphans do
     IO.puts("Cleaning up orphan e2e processes...")
-    System.cmd("pkill", ["-9", "-f", "concord_e2e"], stderr_to_stdout: true)
+    # Use more specific pattern to only kill node processes (concord_e2e\d+@)
+    System.cmd("pkill", ["-9", "-f", "concord_e2e[0-9]+@"], stderr_to_stdout: true)
     Process.sleep(500)
   end
 end
@@ -45,7 +47,8 @@ end
 # Register cleanup on exit
 System.at_exit(fn _ ->
   IO.puts("\nCleaning up e2e processes on exit...")
-  System.cmd("pkill", ["-9", "-f", "concord_e2e"], stderr_to_stdout: true)
+  # Use specific pattern to only kill node processes
+  System.cmd("pkill", ["-9", "-f", "concord_e2e[0-9]+@"], stderr_to_stdout: true)
 end)
 
 # Start ExUnit with specific configuration for e2e tests

scripts/run_e2e_tests.sh

@@ -13,10 +13,11 @@ NC='\033[0m' # No Color
 # Set MIX_ENV
 export MIX_ENV=e2e_test
 
-# Function to clean up orphan processes
+# Function to clean up orphan node processes
 cleanup() {
     echo -e "\n${YELLOW}Cleaning up e2e processes...${NC}"
-    pkill -9 -f "concord_e2e" 2>/dev/null || true
+    # Use specific pattern to only kill node processes (concord_e2e1@, concord_e2e2@, etc.)
+    pkill -9 -f "concord_e2e[0-9]+@" 2>/dev/null || true
     rm -rf ./data/e2e_test 2>/dev/null || true
 }