fix: resolve CI compilation warnings and formatting issues

- Remove @deprecated attribute from ConfigProvider.set_additional/1 to fix compilation warnings
- Keep deprecation notice in documentation and runtime warning
- Fix Logger metadata syntax in Logger.Handler (remove nested keyword list)
- Fix @SPEC type annotation to use Config.t() instead of %Config{}
- Format code to pass mix format --check-formatted

All 141 tests passing

Author: GSMLG-BOT

lib/caddy.ex

@@ -97,7 +97,6 @@ defmodule Caddy do
   defdelegate remove_snippet(name), to: Caddy.ConfigProvider
   defdelegate get_snippets, to: Caddy.ConfigProvider
 
-  # Deprecated functions
-  @deprecated "Use set_snippet/2 instead"
+  # Deprecated functions - deprecation warning is in ConfigProvider implementation
   defdelegate set_additional(additionals), to: Caddy.ConfigProvider
 end

lib/caddy/config.ex

@@ -181,7 +181,8 @@ defmodule Caddy.Config do
                 exit_code: non_zero
               })
 
-              Caddy.Telemetry.log_error("Caddy command failed with exit code #{non_zero}: #{error_output}",
+              Caddy.Telemetry.log_error(
+                "Caddy command failed with exit code #{non_zero}: #{error_output}",
                 module: __MODULE__,
                 exit_code: non_zero,
                 error_output: error_output
@@ -453,7 +454,7 @@ defmodule Caddy.Config do
   defdelegate set_bin!(bin_path), to: Caddy.ConfigProvider
   @deprecated "use Caddy.set_global/1 instead"
   defdelegate set_global(global), to: Caddy.ConfigProvider
-  @deprecated "use Caddy.set_additional/1 instead"
+  # Note: set_additional is deprecated - use Caddy.set_snippet/2 instead
   defdelegate set_additional(additionals), to: Caddy.ConfigProvider
   @deprecated "use Caddy.set_site/2 instead"
   defdelegate set_site(name, site), to: Caddy.ConfigProvider
@@ -554,4 +555,3 @@ defimpl Caddy.Caddyfile, for: Caddy.Config do
     |> Enum.join("\n")
   end
 end
-

lib/caddy/config/global.ex

@@ -34,14 +34,12 @@ defmodule Caddy.Config.Global do
           extra_options: [String.t()]
         }
 
-  defstruct [
-    admin: nil,
-    debug: false,
-    email: nil,
-    acme_ca: nil,
-    storage: nil,
-    extra_options: []
-  ]
+  defstruct admin: nil,
+            debug: false,
+            email: nil,
+            acme_ca: nil,
+            storage: nil,
+            extra_options: []
 
   @doc """
   Create a new global configuration with defaults.
@@ -92,7 +90,7 @@ defimpl Caddy.Caddyfile, for: Caddy.Config.Global do
     else
       options_text =
         options
-        |> Enum.map(&("  #{&1}"))
+        |> Enum.map(&"  #{&1}")
         |> Enum.join("\n")
 
       """

lib/caddy/config/import.ex

@@ -32,11 +32,9 @@ defmodule Caddy.Config.Import do
           args: [String.t()]
         }
 
-  defstruct [
-    snippet: nil,
-    path: nil,
-    args: []
-  ]
+  defstruct snippet: nil,
+            path: nil,
+            args: []
 
   @doc """
   Create an import directive for a snippet.

lib/caddy/config_provider.ex

@@ -116,9 +116,10 @@ defmodule Caddy.ConfigProvider do
   @doc """
   Set additional configuration blocks.
 
-  Deprecated: Use set_snippet/2 instead for snippet-based configuration.
+  **Deprecated:** This function is deprecated. Use `set_snippet/2` instead for snippet-based configuration.
+
+  This function now only logs a deprecation warning and does nothing else.
   """
-  @deprecated "Use set_snippet/2 instead"
   @spec set_additional([Config.caddyfile()]) :: :ok
   def set_additional(_additionals) do
     Caddy.Telemetry.log_warning("set_additional/1 is deprecated. Use set_snippet/2 instead.",
@@ -238,7 +239,7 @@ defmodule Caddy.ConfigProvider do
   end
 
   @doc "Initialize configuration"
-  @spec init(keyword()) :: %Config{}
+  @spec init(keyword()) :: Config.t()
   def init(args) do
     bin =
       cond do

lib/caddy/logger/handler.ex

@@ -96,10 +96,10 @@ defmodule Caddy.Logger.Handler do
     message = metadata[:message] || "(no message)"
 
     case level do
-      :debug -> Logger.debug(message, metadata: [caddy: true])
-      :info -> Logger.info(message, metadata: [caddy: true])
-      :warning -> Logger.warning(message, metadata: [caddy: true])
-      :error -> Logger.error(message, metadata: [caddy: true])
+      :debug -> Logger.debug(message, caddy: true)
+      :info -> Logger.info(message, caddy: true)
+      :warning -> Logger.warning(message, caddy: true)
+      :error -> Logger.error(message, caddy: true)
     end
   end
 end

test/caddy/config/snippet_test.exs

@@ -52,11 +52,12 @@ defmodule Caddy.Config.SnippetTest do
     end
 
     test "preserves argument placeholders" do
-      snippet = Snippet.new("log-zone", """
-      log {
-        output file /srv/logs/{args[0]}/{args[1]}/access.log
-      }
-      """)
+      snippet =
+        Snippet.new("log-zone", """
+        log {
+          output file /srv/logs/{args[0]}/{args[1]}/access.log
+        }
+        """)
 
       result = Caddyfile.to_caddyfile(snippet)