Skip to content

Commit 38a1024

Browse files
committed
fix: Downgrade Go to 1.23 and fix staticcheck errors
- Downgrade Go version from 1.25 to 1.23 in go.mod and all workflows - Fix staticcheck ST1005 errors: error strings should not be capitalized or end with punctuation - Update error messages in cmd/rr.go, cmd/zone.go, cmd/zoneGroup.go to follow Go conventions - Fix terminating error message in cmd/semanticRelease.go Go 1.25 doesn't exist yet; latest stable is 1.23. This fixes the golangci-lint compatibility issue where the linter was built with Go 1.24.
1 parent 49d0697 commit 38a1024

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: Setup Go
2424
uses: actions/setup-go@v5
2525
with:
26-
go-version: '1.25'
26+
go-version: '1.23'
2727

2828
- name: Configure git for private modules
2929
env:
@@ -48,7 +48,7 @@ jobs:
4848
- name: Setup Go
4949
uses: actions/setup-go@v5
5050
with:
51-
go-version: '1.25'
51+
go-version: '1.23'
5252

5353
- name: Configure git for private modules
5454
env:
@@ -90,7 +90,7 @@ jobs:
9090
- name: Setup Go
9191
uses: actions/setup-go@v5
9292
with:
93-
go-version: '1.25'
93+
go-version: '1.23'
9494

9595
- name: Configure git for private modules
9696
env:
@@ -113,7 +113,7 @@ jobs:
113113
- name: Setup Go
114114
uses: actions/setup-go@v5
115115
with:
116-
go-version: '1.25'
116+
go-version: '1.23'
117117

118118
- name: Configure git for private modules
119119
env:
@@ -138,7 +138,7 @@ jobs:
138138
- name: Setup Go
139139
uses: actions/setup-go@v5
140140
with:
141-
go-version: '1.25'
141+
go-version: '1.23'
142142

143143
- name: Configure git for private modules
144144
env:

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: Setup golang
2626
uses: actions/setup-go@v5
2727
with:
28-
go-version: '1.25'
28+
go-version: '1.23'
2929

3030
- name: Configure git for private modules
3131
env:

cmd/rr.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ var rrCmd = &cobra.Command{
2121
Run: func(cmd *cobra.Command, args []string) {
2222
uname := viper.GetString("zdnsuser.username")
2323
if uname == "" {
24-
exitIfError(errors.New("Need login first."))
24+
exitIfError(errors.New("need login first"))
2525
}
2626
token := viper.GetString("zdnsuser.token")
2727
zdns.SetToken(token)

cmd/semanticRelease.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ func semanticReleaseCmdHandler(cmd *cobra.Command, args []string) {
8888
signal.Notify(c, os.Interrupt, syscall.SIGTERM)
8989
go func() {
9090
<-c
91-
exitIfError(errors.New("terminating..."))
91+
exitIfError(errors.New("terminating"))
9292
}()
9393

9494
if conf.DownloadPlugins {

cmd/zone.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Use --create to create with --name zone name, zone name must end with "."
2323
Run: func(cmd *cobra.Command, args []string) {
2424
uname := viper.GetString("zdnsuser.username")
2525
if uname == "" {
26-
exitIfError(errors.New("Need login first."))
26+
exitIfError(errors.New("need login first"))
2727
}
2828
token := viper.GetString("zdnsuser.token")
2929
zdns.SetToken(token)

cmd/zoneGroup.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ to quickly create a Cobra application.`,
2626
Run: func(cmd *cobra.Command, args []string) {
2727
uname := viper.GetString("zdnsuser.username")
2828
if uname == "" {
29-
exitIfError(errors.New("Need login first."))
29+
exitIfError(errors.New("need login first"))
3030
}
3131
token := viper.GetString("zdnsuser.token")
3232
zdns.SetToken(token)

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
module github.com/gsmlg-dev/gsmlg-cli
22

3-
go 1.25
3+
go 1.23
44

5-
toolchain go1.25.0
5+
toolchain go1.23.0
66

77
require (
88
github.com/Masterminds/semver/v3 v3.2.1

0 commit comments

Comments
 (0)