refactor: Rename Request struct fields for clarity

- Renamed  to  for 3rd httpc argument (request-specific)
- Renamed  to  for 4th httpc argument (client-specific)
- Updated all type specifications and documentation comments
- Updated HTTP.fetch/2 to use new field names
- Updated Request.to_httpc_args/1 to use new field mapping
- Updated tests to use new field names

This change makes the field names more intuitive and aligns them with:
- : HTTP-specific options (timeout, SSL, redirects, etc.)
- : General client options (sync, body_format, streaming, etc.)

Maintains full backward compatibility while improving code clarity.

Author: GSMLG-BOT

lib/http.ex

@@ -172,10 +172,10 @@ defmodule HTTP do
       headers: HTTP.FetchOptions.get_headers(options),
       body: HTTP.FetchOptions.get_body(options),
       content_type: HTTP.FetchOptions.get_content_type(options),
-      # Maps to Request.options (3rd arg for :httpc.request)
-      options: options.options,
-      # Maps to Request.opts (4th arg for :httpc.request)
-      opts: Keyword.merge(Request.__struct__().opts, options.opts)
+      # Maps to Request.http_options (3rd arg for :httpc.request)
+      http_options: options.options,
+      # Maps to Request.options (4th arg for :httpc.request)
+      options: Keyword.merge(Request.__struct__().options, options.opts)
     }
 
     # Extract AbortController PID from FetchOptions

lib/http/request.ex

@@ -3,17 +3,17 @@ defmodule HTTP.Request do
   Represents an HTTP request that can be serialized into :httpc.request arguments.
   """
 
-  # Note: `options` are for the 3rd argument of :httpc.request (request-specific options like timeout).
-  # `opts` are for the 4th argument of :httpc.request (client-specific options like sync/body_format).
+  # Note: `http_options` are for the 3rd argument of :httpc.request (request-specific options like timeout).
+  # `options` are for the 4th argument of :httpc.request (client-specific options like sync/body_format).
   defstruct method: :get,
             url: nil,
             headers: %HTTP.Headers{},
             # Separate field for Content-Type header
             content_type: nil,
             body: nil,
             # HTTPC request options (e.g., timeout)
-            options: [],
-            opts: [sync: false]
+            http_options: [],
+            options: [sync: false]
 
   @type method :: :head | :get | :post | :put | :delete | :patch
   @type url :: URI.t()
@@ -28,8 +28,8 @@ defmodule HTTP.Request do
           headers: HTTP.Headers.t(),
           content_type: content_type,
           body: body_content,
-          options: httpc_options,
-          opts: httpc_client_opts
+          http_options: httpc_options,
+          options: httpc_client_opts
         }
 
   @doc """
@@ -73,7 +73,7 @@ defmodule HTTP.Request do
           {url, headers, content_type, body_content}
       end
 
-    [method, request_tuple, req.options, req.opts]
+    [method, request_tuple, req.http_options, req.options]
   end
 
   @spec to_body(body_content()) :: charlist()

test/http/request_test.exs

@@ -7,7 +7,8 @@ defmodule HTTP.RequestTest do
       request = %HTTP.Request{}
       assert request.method == :get
       assert %HTTP.Headers{headers: []} = request.headers
-      assert request.options == []
+      assert request.http_options == []
+      assert request.options == [sync: false]
     end
 
     test "create request with custom values" do
@@ -34,7 +35,7 @@ defmodule HTTP.RequestTest do
         headers: HTTP.Headers.new([{"Accept", "application/json"}])
       }
 
-      [method, request_tuple, _options, _opts] = HTTP.Request.to_httpc_args(request)
+      [method, request_tuple, _http_options, _options] = HTTP.Request.to_httpc_args(request)
       assert method == :get
       assert request_tuple == {~c"http://example.com", [{~c"Accept", ~c"application/json"}]}
     end