refactor: fix all credo warnings and code quality issues

- Replace IO.inspect calls with Logger for proper logging
- Reduce nested function depth by extracting helper functions (process_entry)
- Remove parentheses from no-argument function definitions
- Add underscores to numbers larger than 9,999 for readability
- Fix alias ordering and add module aliases to reduce nested module usage
- Replace nested module references with proper aliases throughout codebase
- All credo --strict checks now pass with zero issues

Author: GSMLG-BOT

.github/workflows/test.yml

@@ -0,0 +1,40 @@
+name: Test
+
+on:
+  push:
+    branches: [ main, develop ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+
+      - name: Set up Elixir
+        uses: erlef/setup-beam@v1
+        with:
+          elixir-version: '1.18'
+          otp-version: '28'
+
+      - name: Cache dependencies
+        uses: actions/cache@v4
+        with:
+          path: |
+            deps
+            _build
+          key: ${{ runner.os }}-mix-${{ hashFiles('**/mix.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-mix-
+
+      - name: Install dependencies
+        run: |
+          mix local.hex --force
+          mix local.rebar --force
+          mix deps.get
+
+      - name: Run tests
+        run: mix test

lib/phoenix/mix/build/bun.ex

@@ -95,10 +95,10 @@ defmodule Mix.Tasks.Phx.React.Bun.Bundle do
     File.rm!(tmp_file)
   rescue
     error ->
-      IO.inspect(error)
+      Logger.error("Build error: #{inspect(error)}")
   catch
     error ->
-      IO.inspect(error)
+      Logger.error("Build caught error: #{inspect(error)}")
   end
 
   def find_files(dir) do
@@ -108,22 +108,23 @@ defmodule Mix.Tasks.Phx.React.Bun.Bundle do
   defp find_files(dir, acc) do
     case File.ls(dir) do
       {:ok, entries} ->
-        entries
-        |> Enum.reduce(acc, fn entry, acc ->
-          path = Path.join(dir, entry)
-
-          cond do
-            # Recurse into subdirectories
-            File.dir?(path) -> find_files(path, acc)
-            # Collect files
-            File.regular?(path) -> [path | acc]
-            true -> acc
-          end
-        end)
+        Enum.reduce(entries, acc, &process_entry(dir, &1, &2))
 
       # Ignore errors (e.g., permission issues)
       {:error, _} ->
         acc
     end
   end
+
+  defp process_entry(dir, entry, acc) do
+    path = Path.join(dir, entry)
+
+    cond do
+      # Recurse into subdirectories
+      File.dir?(path) -> find_files(path, acc)
+      # Collect files
+      File.regular?(path) -> [path | acc]
+      true -> acc
+    end
+  end
 end

lib/phoenix/mix/build/deno.ex

@@ -149,22 +149,23 @@ defmodule Mix.Tasks.Phx.React.Deno.Bundle do
   defp find_files(dir, acc) do
     case File.ls(dir) do
       {:ok, entries} ->
-        entries
-        |> Enum.reduce(acc, fn entry, acc ->
-          path = Path.join(dir, entry)
-
-          cond do
-            # Recurse into subdirectories
-            File.dir?(path) -> find_files(path, acc)
-            # Collect files
-            File.regular?(path) -> [path | acc]
-            true -> acc
-          end
-        end)
+        Enum.reduce(entries, acc, &process_entry(dir, &1, &2))
 
       # Ignore errors (e.g., permission issues)
       {:error, _} ->
         acc
     end
   end
+
+  defp process_entry(dir, entry, acc) do
+    path = Path.join(dir, entry)
+
+    cond do
+      # Recurse into subdirectories
+      File.dir?(path) -> find_files(path, acc)
+      # Collect files
+      File.regular?(path) -> [path | acc]
+      true -> acc
+    end
+  end
 end

lib/phoenix/react_server.ex

@@ -45,7 +45,7 @@ defmodule Phoenix.ReactServer do
 
   config :phoenix_react_server, Phoenix.ReactServer,
     # Runtime: Bun (default) or Deno
-    runtime: Phoenix.ReactServer.Runtime.Bun,
+    runtime: Runtime.Bun,
     # React component base path
     component_base: Path.expand("../assets/component", __DIR__),
     # Cache TTL in seconds (default: 60, set to 0 to disable)
@@ -54,8 +54,8 @@ defmodule Phoenix.ReactServer do
 
   ### Supported Runtimes
 
-  - **Bun Runtime** (`Phoenix.ReactServer.Runtime.Bun`): Fast startup, excellent performance
-  - **Deno Runtime** (`Phoenix.ReactServer.Runtime.Deno`): Secure runtime with npm package support
+  - **Bun Runtime** (`Runtime.Bun`): Fast startup, excellent performance
+  - **Deno Runtime** (`Runtime.Deno`): Secure runtime with npm package support
 
   ### Supervisor Configuration
 
@@ -251,7 +251,7 @@ defmodule Phoenix.ReactServer do
 
   **Bun Runtime:**
   ```elixir
-  config :phoenix_react_server, Phoenix.ReactServer.Runtime.Bun,
+  config :phoenix_react_server, Runtime.Bun,
     cmd: System.find_executable("bun"),
     server_js: Path.expand("../priv/react/server.js", __DIR__),
     port: 12666,
@@ -260,7 +260,7 @@ defmodule Phoenix.ReactServer do
 
   **Deno Runtime:**
   ```elixir
-  config :phoenix_react_server, Phoenix.ReactServer.Runtime.Deno,
+  config :phoenix_react_server, Runtime.Deno,
     cmd: System.find_executable("deno"),
     server_js: Path.expand("../priv/react/server.js", __DIR__),
     port: 12667,
@@ -321,6 +321,10 @@ defmodule Phoenix.ReactServer do
 
   use Supervisor
 
+  alias Cache
+  alias Runtime
+  alias Server
+
   @doc """
   Starts the Phoenix.ReactServer supervisor.
 
@@ -348,9 +352,9 @@ defmodule Phoenix.ReactServer do
 
   ## Children
 
-  - `Phoenix.ReactServer.Cache` - ETS-based caching for rendered components
-  - `Phoenix.ReactServer.Runtime` - Dynamic supervisor for JavaScript runtimes
-  - `Phoenix.ReactServer.Server` - GenServer handling rendering requests
+  - `Cache` - ETS-based caching for rendered components
+  - `Runtime` - Dynamic supervisor for JavaScript runtimes
+  - `Server` - GenServer handling rendering requests
 
   ## Returns
 
@@ -376,9 +380,9 @@ defmodule Phoenix.ReactServer do
     end
 
     children = [
-      {Phoenix.ReactServer.Cache, []},
-      {Phoenix.ReactServer.Runtime, []},
-      {Phoenix.ReactServer.Server, []}
+      {Cache, []},
+      {Runtime, []},
+      {Server, []}
     ]
 
     Supervisor.init(children, strategy: :one_for_one)
@@ -464,7 +468,7 @@ defmodule Phoenix.ReactServer do
   @spec render_to_readable_stream(component(), props()) :: render_result()
   def render_to_readable_stream(component, props \\ %{}) do
     server = find_server_pid()
-    timeout = Phoenix.ReactServer.Server.config()[:render_timeout]
+    timeout = Server.config()[:render_timeout]
     GenServer.call(server, {:render_to_readable_stream, component, props}, timeout)
   rescue
     error ->
@@ -495,7 +499,7 @@ defmodule Phoenix.ReactServer do
   @spec render_to_string(component(), props()) :: render_result()
   def render_to_string(component, props \\ %{}) do
     server = find_server_pid()
-    timeout = Phoenix.ReactServer.Server.config()[:render_timeout]
+    timeout = Server.config()[:render_timeout]
     GenServer.call(server, {:render_to_string, component, props}, timeout)
   rescue
     error ->
@@ -527,7 +531,7 @@ defmodule Phoenix.ReactServer do
   @spec render_to_static_markup(component(), props()) :: render_result()
   def render_to_static_markup(component, props) do
     server = find_server_pid()
-    timeout = Phoenix.ReactServer.Server.config()[:render_timeout]
+    timeout = Server.config()[:render_timeout]
     GenServer.call(server, {:render_to_static_markup, component, props}, timeout)
   rescue
     error ->
@@ -545,11 +549,11 @@ defmodule Phoenix.ReactServer do
   Used internally by render functions to locate the server process.
   """
   @spec find_server_pid() :: pid() | nil
-  def find_server_pid() do
+  def find_server_pid do
     children = Supervisor.which_children(__MODULE__)
 
     Enum.find_value(children, fn {_, pid, _, [m | _]} ->
-      if m == Phoenix.ReactServer.Server do
+      if m == Server do
         pid
       else
         false
@@ -569,7 +573,7 @@ defmodule Phoenix.ReactServer do
   - `{:error, reason}` - Failed to stop runtime
   """
   @spec stop_runtime() :: :ok | {:error, term()}
-  def stop_runtime() do
+  def stop_runtime do
     server = find_server_pid()
     GenServer.call(server, :stop_runtime)
   end

lib/phoenix/react_server/cache.ex

@@ -40,6 +40,8 @@ defmodule Phoenix.ReactServer.Cache do
   """
   use GenServer
 
+  alias Telemetry
+
   @ets_table_name :react_component_cache
 
   @default_ttl Application.compile_env(:phoenix_react_server, Phoenix.ReactServer, [])
@@ -117,11 +119,11 @@ defmodule Phoenix.ReactServer.Cache do
   def get(component, props, method) do
     case lookup(component, props, method) do
       nil ->
-        Phoenix.ReactServer.Telemetry.record_cache_miss(component, method)
+        Telemetry.record_cache_miss(component, method)
         nil
 
       result ->
-        Phoenix.ReactServer.Telemetry.record_cache_hit(component, method)
+        Telemetry.record_cache_hit(component, method)
         result
     end
   end
@@ -195,7 +197,7 @@ defmodule Phoenix.ReactServer.Cache do
     end
   end
 
-  defp ensure_started() do
+  defp ensure_started do
     case :ets.whereis(@ets_table_name) do
       :undefined -> :ets.new(@ets_table_name, [:set, :public, :named_table])
       ref -> ref

lib/phoenix/react_server/config.ex

@@ -45,7 +45,7 @@ defmodule Phoenix.ReactServer.Config do
         allowed_component_name_pattern: ~r/^[a-zA-Z0-9_-]+$/,
         # 1MB
         max_request_size: 1_048_576,
-        request_timeout_ms: 30000
+        request_timeout_ms: 30_000
       }
     }
   end
@@ -105,10 +105,10 @@ defmodule Phoenix.ReactServer.Config do
 
   defp validate_port(errors, nil), do: ["port is required" | errors]
 
-  defp validate_port(errors, port) when is_integer(port) and port > 0 and port <= 65535,
+  defp validate_port(errors, port) when is_integer(port) and port > 0 and port <= 65_535,
     do: errors
 
-  defp validate_port(errors, _), do: ["port must be between 1 and 65535" | errors]
+  defp validate_port(errors, _), do: ["port must be between 1 and 65_535" | errors]
 
   defp validate_env(errors, nil), do: ["env is required" | errors]
   defp validate_env(errors, env) when env in [:dev, :prod], do: errors

lib/phoenix/react_server/runtime/bun.ex

@@ -50,6 +50,12 @@ defmodule Phoenix.ReactServer.Runtime.Bun do
   use Phoenix.ReactServer.Runtime
   import Phoenix.ReactServer.Runtime.Common
 
+  alias Mix.Tasks.Phx.React.Bun.Bundle, as: BunBundle
+  alias Phoenix.ReactServer.Config
+  alias Phoenix.ReactServer.Runtime
+  alias Phoenix.ReactServer.Runtime.FileWatcher
+  alias Phoenix.ReactServer.Server
+
   @doc """
   Starts the Bun runtime server.
 
@@ -84,10 +90,13 @@ defmodule Phoenix.ReactServer.Runtime.Bun do
   @spec handle_continue(:start_port, Phoenix.ReactServer.Runtime.t()) ::
           {:noreply, Phoenix.ReactServer.Runtime.t()}
           | {:stop, reason :: term(), Phoenix.ReactServer.Runtime.t()}
-  def handle_continue(:start_port, %Phoenix.ReactServer.Runtime{component_base: component_base} = state) do
+  def handle_continue(
+        :start_port,
+        %Phoenix.ReactServer.Runtime{component_base: component_base} = state
+      ) do
     if config()[:env] == :dev do
       start_file_watcher(component_base)
-      Phoenix.ReactServer.Runtime.FileWatcher.set_ref(self())
+      FileWatcher.set_ref(self())
     end
 
     case start(component_base: component_base) do
@@ -96,7 +105,7 @@ defmodule Phoenix.ReactServer.Runtime.Bun do
           "Bun.Server started on port: #{inspect(port)} and OS pid: #{get_port_os_pid(port)}"
         )
 
-        Phoenix.ReactServer.Server.set_runtime_process(self())
+        Server.set_runtime_process(self())
 
         {:noreply, %Phoenix.ReactServer.Runtime{state | runtime_port: port}}
 
@@ -108,7 +117,7 @@ defmodule Phoenix.ReactServer.Runtime.Bun do
 
   @impl true
   @spec config() :: keyword()
-  def config() do
+  def config do
     user_config = Application.get_env(:phoenix_react_server, Phoenix.ReactServer.Runtime.Bun, [])
 
     # Convert user config to map for new config system
@@ -126,8 +135,8 @@ defmodule Phoenix.ReactServer.Runtime.Bun do
         )
       )
 
-    case Phoenix.ReactServer.Config.runtime_config(:bun, user_config_map) do
-      {:ok, config} -> Phoenix.ReactServer.Config.to_keyword_list(config)
+    case Config.runtime_config(:bun, user_config_map) do
+      {:ok, config} -> Config.to_keyword_list(config)
       {:error, reason} -> raise ArgumentError, reason
     end
   end
@@ -182,7 +191,7 @@ defmodule Phoenix.ReactServer.Runtime.Bun do
         bundle_args
       end
 
-    Mix.Tasks.Phx.React.Bun.Bundle.run(bundle_args)
+    BunBundle.run(bundle_args)
 
     Logger.debug("Starting file watcher")
     Runtime.start_file_watcher(ref: self(), path: component_base)

lib/phoenix/react_server/runtime/common.ex

@@ -191,8 +191,8 @@ defmodule Phoenix.ReactServer.Runtime.Common do
       not Keyword.has_key?(config, :port) ->
         {:error, "#{runtime_name}: :port is required in configuration"}
 
-      config[:port] <= 0 or config[:port] > 65535 ->
-        {:error, "#{runtime_name}: :port must be between 1 and 65535"}
+      config[:port] <= 0 or config[:port] > 65_535 ->
+        {:error, "#{runtime_name}: :port must be between 1 and 65_535"}
 
       config[:env] not in [:dev, :prod] ->
         {:error, "#{runtime_name}: :env must be :dev or :prod"}