Skip to content

Commit 37f132b

Browse files
committed
test: update test files to use new start_session API with options
1 parent e8eac9b commit 37f132b

File tree

3 files changed

+40
-15
lines changed

3 files changed

+40
-15
lines changed

test/phoenix/session_process/integration_test.exs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,10 @@ defmodule Phoenix.SessionProcess.IntegrationTest do
4646

4747
# Start with custom module
4848
assert {:ok, _pid} =
49-
SessionProcess.start_session(session_id, module: TestCustomSession, args: %{test: "data"})
49+
SessionProcess.start_session(session_id,
50+
module: TestCustomSession,
51+
args: %{test: "data"}
52+
)
5053

5154
# Verify custom initialization worked
5255
assert %{custom: true} = SessionProcess.call(session_id, :get_state)

test/phoenix/session_process/macro_consistency_test.exs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ defmodule Phoenix.SessionProcess.MacroConsistencyTest do
3232
session_id = "test_process_with_arg_#{:rand.uniform(10000)}"
3333
init_arg = %{user_id: 123, data: "test"}
3434

35-
{:ok, _pid} = SessionProcess.start_session(session_id, module: TestProcessWithArg, args: init_arg)
35+
{:ok, _pid} =
36+
SessionProcess.start_session(session_id, module: TestProcessWithArg, args: init_arg)
3637

3738
state = SessionProcess.call(session_id, :get_state)
3839
assert state.initialized_with == init_arg
@@ -44,7 +45,8 @@ defmodule Phoenix.SessionProcess.MacroConsistencyTest do
4445
session_id = "test_process_with_arg_#{:rand.uniform(10000)}"
4546
init_arg = %{user_id: 456, data: "test"}
4647

47-
{:ok, _pid} = SessionProcess.start_session(session_id, module: TestProcessLinkWithArg, args: init_arg)
48+
{:ok, _pid} =
49+
SessionProcess.start_session(session_id, module: TestProcessLinkWithArg, args: init_arg)
4850

4951
state = SessionProcess.call(session_id, :get_state)
5052
assert state.initialized_with == init_arg
@@ -61,8 +63,11 @@ defmodule Phoenix.SessionProcess.MacroConsistencyTest do
6163
init_arg = %{value: 42}
6264

6365
# Both should accept the same argument format
64-
{:ok, _} = SessionProcess.start_session(session_id_1, module: TestProcessWithArg, args: init_arg)
65-
{:ok, _} = SessionProcess.start_session(session_id_2, module: TestProcessLinkWithArg, args: init_arg)
66+
{:ok, _} =
67+
SessionProcess.start_session(session_id_1, module: TestProcessWithArg, args: init_arg)
68+
69+
{:ok, _} =
70+
SessionProcess.start_session(session_id_2, module: TestProcessLinkWithArg, args: init_arg)
6671

6772
state1 = SessionProcess.call(session_id_1, :get_state)
6873
state2 = SessionProcess.call(session_id_2, :get_state)

test/phoenix/session_process_test.exs

Lines changed: 27 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ defmodule Phoenix.SessionProcessTest do
4343

4444
test "test call on session process" do
4545
session_id = SessionId.generate_unique_session_id()
46-
{:ok, _pid} = SessionProcess.start_session(session_id, module: TestProcess, args: %{value: 123})
46+
47+
{:ok, _pid} =
48+
SessionProcess.start_session(session_id, module: TestProcess, args: %{value: 123})
49+
4750
assert SessionProcess.call(session_id, :get_value) == 123
4851
end
4952

@@ -64,8 +67,11 @@ defmodule Phoenix.SessionProcessTest do
6467
session_id1 = SessionId.generate_unique_session_id()
6568
session_id2 = SessionId.generate_unique_session_id()
6669

67-
{:ok, pid1} = SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
68-
{:ok, pid2} = SessionProcess.start_session(session_id2, module: TestProcess, args: %{value: 2})
70+
{:ok, pid1} =
71+
SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
72+
73+
{:ok, pid2} =
74+
SessionProcess.start_session(session_id2, module: TestProcess, args: %{value: 2})
6975

7076
sessions = SessionProcess.list_session()
7177
# Check that our created sessions are in the list
@@ -79,7 +85,9 @@ defmodule Phoenix.SessionProcessTest do
7985

8086
test "removes session when terminated" do
8187
session_id = SessionId.generate_unique_session_id()
82-
{:ok, pid} = SessionProcess.start_session(session_id, module: TestProcess, args: %{value: 0})
88+
89+
{:ok, pid} =
90+
SessionProcess.start_session(session_id, module: TestProcess, args: %{value: 0})
8391

8492
# Check session exists in list
8593
sessions_before = SessionProcess.list_session()
@@ -101,8 +109,11 @@ defmodule Phoenix.SessionProcessTest do
101109
session_id1 = SessionId.generate_unique_session_id()
102110
session_id2 = SessionId.generate_unique_session_id()
103111

104-
{:ok, _pid1} = SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
105-
{:ok, _pid2} = SessionProcess.start_session(session_id2, module: TestProcess, args: %{value: 2})
112+
{:ok, _pid1} =
113+
SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
114+
115+
{:ok, _pid2} =
116+
SessionProcess.start_session(session_id2, module: TestProcess, args: %{value: 2})
106117

107118
sessions = SessionProcess.list_sessions_by_module(TestProcess)
108119
# Check that our created sessions are in the list
@@ -118,7 +129,8 @@ defmodule Phoenix.SessionProcessTest do
118129
session_id1 = SessionId.generate_unique_session_id()
119130
session_id2 = SessionId.generate_unique_session_id()
120131

121-
{:ok, _pid1} = SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
132+
{:ok, _pid1} =
133+
SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
122134

123135
{:ok, _pid2} =
124136
SessionProcess.start_session(session_id2, module: TestProcessLink, args: %{value: 2})
@@ -152,7 +164,8 @@ defmodule Phoenix.SessionProcessTest do
152164
session_id1 = SessionId.generate_unique_session_id()
153165
session_id2 = SessionId.generate_unique_session_id()
154166

155-
{:ok, _pid1} = SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
167+
{:ok, _pid1} =
168+
SessionProcess.start_session(session_id1, module: TestProcess, args: %{value: 1})
156169

157170
{:ok, _pid2} =
158171
SessionProcess.start_session(session_id2, module: TestProcessLink, args: %{value: 2})
@@ -173,7 +186,9 @@ defmodule Phoenix.SessionProcessTest do
173186
describe "get_session_id/0 in :process macro" do
174187
test "returns correct session_id from within session process" do
175188
session_id = SessionId.generate_unique_session_id()
176-
{:ok, _pid} = SessionProcess.start_session(session_id, module: TestProcess, args: %{value: 0})
189+
190+
{:ok, _pid} =
191+
SessionProcess.start_session(session_id, module: TestProcess, args: %{value: 0})
177192

178193
# Call a function that uses get_session_id internally
179194
result = SessionProcess.call(session_id, :get_my_session_id)
@@ -184,7 +199,9 @@ defmodule Phoenix.SessionProcessTest do
184199
describe "get_session_id/0 with LiveView monitoring" do
185200
test "returns correct session_id from within session process" do
186201
session_id = SessionId.generate_unique_session_id()
187-
{:ok, _pid} = SessionProcess.start_session(session_id, module: TestProcessLink, args: %{value: 0})
202+
203+
{:ok, _pid} =
204+
SessionProcess.start_session(session_id, module: TestProcessLink, args: %{value: 0})
188205

189206
result = SessionProcess.call(session_id, :get_my_session_id)
190207
assert result == session_id

0 commit comments

Comments
 (0)