Drop redundant check in skipOptionalSVGSpacesOrDelimiter

Ahmad-S792 · Ahmad Saleem · commit 56bcdb9d3730 · 2023-10-18T11:16:48.000-07:00
https://bugs.webkit.org/show_bug.cgi?id=263272 Reviewed by Simon Fraser. Merge: https://chromium-review.googlesource.com/c/chromium/src/+/2642784 skipOptionalSVGSpaces() returns true if this condition (m_position < m_end) is true, so we don't need to check it again. * Source/WebCore/svg/SVGParserUtilities.h: (skipOptionalSVGSpacesOrDelimiter): Canonical link: https://commits.webkit.org/269478@main
diff --git a/Source/WebCore/svg/SVGParserUtilities.h b/Source/WebCore/svg/SVGParserUtilities.h
@@ -98,7 +98,7 @@ template<typename CharacterType> constexpr bool skipOptionalSVGSpacesOrDelimiter
     if (characters.hasCharactersRemaining() && !isSVGSpace(*characters) && *characters != delimiter)
         return false;
     if (skipOptionalSVGSpaces(characters)) {
-        if (characters.hasCharactersRemaining() && *characters == delimiter) {
+        if (*characters == delimiter) {
             characters++;
             skipOptionalSVGSpaces(characters);
         }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ template<typename CharacterType> constexpr bool skipOptionalSVGSpacesOrDelimiter`
`98`	`98`	`if (characters.hasCharactersRemaining() && !isSVGSpace(characters) && characters != delimiter)`
`99`	`99`	`return false;`
`100`	`100`	`if (skipOptionalSVGSpaces(characters)) {`
`101`		`- if (characters.hasCharactersRemaining() && *characters == delimiter) {`
	`101`	`+ if (*characters == delimiter) {`
`102`	`102`	`characters++;`
`103`	`103`	`skipOptionalSVGSpaces(characters);`
`104`	`104`	`}`