Fix flaky drag and drop test

pvollan · pvollan · commit df3d039f2f08 · 2023-10-18T10:48:22.000-07:00
https://bugs.webkit.org/show_bug.cgi?id=263279 rdar://115155299 Reviewed by Brent Fulgham and Ryosuke Niwa. Start the test in the body's onload handler when everything has been parsed, since 261705@main changed behavior in HTML parser yielding. * LayoutTests/editing/pasteboard/datatransfer-types-dropping-text-file-promise.html: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/269475@main
diff --git a/LayoutTests/editing/pasteboard/datatransfer-types-dropping-text-file-promise.html b/LayoutTests/editing/pasteboard/datatransfer-types-dropping-text-file-promise.html
@@ -1,13 +1,12 @@
 <!DOCTYPE html>
 <html>
-<body>
+<body onload="onLoad()">
 <div id="target" contentEditable="true" ondrop="check(event)"></div>
 <script src="../../resources/js-test-pre.js"></script>
 <script>
 description('When dropping a file promise, dataTransfer.types must contain "Files" and not "text/uri-list". This test requires eventSender.beginDragWithFilePromises.');
 
 function runTest() {
-    jsTestIsAsync = true;
     const target = document.getElementById('target');
     eventSender.beginDragWithFilePromises(['../resources/abe.png']);
     eventSender.mouseMoveTo(target.offsetLeft + 5, target.offsetTop + 5);
@@ -22,12 +21,16 @@
     finishJSTest();
 }
 
-if (window.eventSender)
-    runTest();
-else
-    testFailed('This test requires eventSender.beginDragWithFilePromises');
+function onLoad() {
+    if (window.eventSender)
+        runTest();
+    else
+        testFailed('This test requires eventSender.beginDragWithFilePromises');
+}
 
+jsTestIsAsync = true;
 var successfullyParsed = true;
+
 </script>
 <script src="../../resources/js-test-post.js"></script>
 </body>
diff --git a/LayoutTests/platform/mac-wk1/TestExpectations b/LayoutTests/platform/mac-wk1/TestExpectations
@@ -18,7 +18,7 @@ editing/pasteboard/data-transfer-set-data-sanitize-html-when-dragging-in-null-or
 editing/pasteboard/data-transfer-set-data-sanitize-url-when-dragging-in-null-origin.html [ Pass ]
 editing/pasteboard/data-transfer-item-list-add-file-on-drag.html [ Pass ]
 editing/pasteboard/datatransfer-items-drop-plaintext-file-promise.html [ Pass ]
-webkit.org/b/261318 editing/pasteboard/datatransfer-types-dropping-text-file-promise.html [ Pass Failure ] # change this back to "Pass" once fixed
+editing/pasteboard/datatransfer-types-dropping-text-file-promise.html [ Pass ]
 editing/pasteboard/drag-drop-href-as-url.html [ Pass ]
 editing/pasteboard/drag-end-crash-accessing-item-list.html [ Pass ]
 editing/pasteboard/drag-file-promises-to-editable-element-as-URLs.html [ Pass ]
