[COSMETIC] Renames the method and attributes so they use camlCase (openscad#5628)

* [COSMETIC] Renames the method and attributes so they use camlCase

It seems that both camlCase and joint_lower naming scheme are used in openScad,
with more names in camlCase. In this PR I renames the ones that were
using joint_lower scheme to unify with camlCase.

Author: damienmarchal

src/gui/Animate.cc

@@ -32,18 +32,18 @@ Animate::Animate(QWidget *parent) : QWidget(parent)
 
 void Animate::initGUI()
 {
-  this->anim_step = 0;
-  this->anim_numsteps = 0;
-  this->anim_tval = 0.0;
-  this->anim_dumping = false;
-  this->anim_dump_start_step = 0;
+    this->animStep = 0;
+    this->animNumSteps = 0;
+  this->animTVal = 0.0;
+    this->animDumping = false;
+  this->animDumpStartStep = 0;
 
   this->iconRun = QIcon::fromTheme("chokusen-animate-play");
   this->iconPause = QIcon::fromTheme("chokusen-animate-pause");
   this->iconDisabled = QIcon::fromTheme("chokusen-animate-disabled");
 
-  animate_timer = new QTimer(this);
-  connect(animate_timer, SIGNAL(timeout()), this, SLOT(incrementTVal()));
+    animateTimer = new QTimer(this);
+    connect(animateTimer, SIGNAL(timeout()), this, SLOT(incrementTVal()));
 
   connect(this->e_tval, SIGNAL(textChanged(QString)), this, SLOT(updatedAnimTval()));
   connect(this->e_fps, SIGNAL(textChanged(QString)), this, SLOT(updatedAnimFpsAndAnimSteps()));
@@ -66,44 +66,44 @@ void Animate::setMainWindow(MainWindow *mainWindow)
 void Animate::connectAction(QAction *action, QPushButton *button)
 {
   connect(action, &QAction::triggered, button, &QPushButton::click);
-  this->action_list.append(action);
+  this->actionList.append(action);
 }
 
 void Animate::updatedAnimTval()
 {
-  double t = this->e_tval->text().toDouble(&this->t_ok);
+    double t = this->e_tval->text().toDouble(&this->tOK);
   // Clamp t to 0-1
-  if (this->t_ok) {
+    if (this->tOK) {
     t = t < 0 ? 0.0 : ((t > 1.0) ? 1.0 : t);
   } else {
     t = 0.0;
   }
 
-  this->anim_tval = t;
+  this->animTVal = t;
   emit mainWindow->actionRenderPreview();
 
   updatePauseButtonIcon();
 }
 
 void Animate::updatedAnimFpsAndAnimSteps()
 {
-  animate_timer->stop();
+    animateTimer->stop();
 
   int numsteps = this->e_fsteps->text().toInt(&this->steps_ok);
   if (this->steps_ok) {
-    this->anim_numsteps = numsteps;
+      this->animNumSteps = numsteps;
   } else {
-    this->anim_numsteps = 0;
+      this->animNumSteps = 0;
   }
-  this->anim_dumping = false;
-
-  double fps = this->e_fps->text().toDouble(&this->fps_ok);
-  animate_timer->stop();
-  if (this->fps_ok && fps > 0 && this->anim_numsteps > 0) {
-    this->anim_step = int(this->anim_tval * this->anim_numsteps) % this->anim_numsteps;
-    animate_timer->setSingleShot(false);
-    animate_timer->setInterval(int(1000 / fps));
-    animate_timer->start();
+  this->animDumping = false;
+
+  double fps = this->e_fps->text().toDouble(&this->fpsOK);
+  animateTimer->stop();
+  if (this->fpsOK && fps > 0 && this->animNumSteps > 0) {
+      this->animStep = int(this->animTVal * this->animNumSteps) % this->animNumSteps;
+      animateTimer->setSingleShot(false);
+      animateTimer->setInterval(int(1000 / fps));
+      animateTimer->start();
   }
 
   QPalette defaultPalette;
@@ -116,7 +116,7 @@ void Animate::updatedAnimFpsAndAnimSteps()
     this->e_fsteps->setStyleSheet(redStyleSheet);
   }
 
-  if (this->fps_ok || this->e_fps->text() == "") {
+  if (this->fpsOK || this->e_fps->text() == "") {
     this->e_fps->setStyleSheet("");
   } else {
     this->e_fps->setStyleSheet(redStyleSheet);
@@ -128,65 +128,65 @@ void Animate::updatedAnimFpsAndAnimSteps()
 
 void Animate::updatedAnimDump(bool checked)
 {
-  if (!checked) this->anim_dumping = false;
+    if (!checked) this->animDumping = false;
 
   updatePauseButtonIcon();
 }
 
 // Only called from animate_timer
 void Animate::incrementTVal()
 {
-  if (this->anim_numsteps == 0) return;
+    if (this->animNumSteps == 0) return;
 
   if (mainWindow->windowActionHideCustomizer->isVisible()) {
     if (mainWindow->activeEditor->parameterWidget->childHasFocus()) return;
   }
 
-  if (this->anim_numsteps > 1) {
-    this->anim_step = (this->anim_step + 1) % this->anim_numsteps;
-    this->anim_tval = 1.0 * this->anim_step / this->anim_numsteps;
-  } else if (this->anim_numsteps > 0) {
-    this->anim_step = 0;
-    this->anim_tval = 0.0;
+  if (this->animNumSteps > 1) {
+      this->animStep = (this->animStep + 1) % this->animNumSteps;
+      this->animTVal = 1.0 * this->animStep / this->animNumSteps;
+  } else if (this->animNumSteps > 0) {
+      this->animStep = 0;
+    this->animTVal = 0.0;
   }
 
-  const QString txt = QString::number(this->anim_tval, 'f', 5);
+  const QString txt = QString::number(this->animTVal, 'f', 5);
   this->e_tval->setText(txt);
 
   updatePauseButtonIcon();
 }
 
 void Animate::updateTVal()
 {
-  if (this->anim_numsteps == 0) return;
+    if (this->animNumSteps == 0) return;
 
-  if (this->anim_step < 0) {
-    this->anim_step = this->anim_numsteps - this->anim_step - 2;
+  if (this->animStep < 0) {
+      this->animStep = this->animNumSteps - this->animStep - 2;
   }
 
-  if (this->anim_numsteps > 1) {
-    this->anim_step = (this->anim_step) % this->anim_numsteps;
-    this->anim_tval = 1.0 * this->anim_step / this->anim_numsteps;
-  } else if (this->anim_numsteps > 0) {
-    this->anim_step = 0;
-    this->anim_tval = 0.0;
+  if (this->animNumSteps > 1) {
+      this->animStep = (this->animStep) % this->animNumSteps;
+      this->animTVal = 1.0 * this->animStep / this->animNumSteps;
+  } else if (this->animNumSteps > 0) {
+      this->animStep = 0;
+    this->animTVal = 0.0;
   }
 
-  const QString txt = QString::number(this->anim_tval, 'f', 5);
+  const QString txt = QString::number(this->animTVal, 'f', 5);
   this->e_tval->setText(txt);
 
   updatePauseButtonIcon();
 }
 
 void Animate::pauseAnimation(){
-  animate_timer->stop();
+    animateTimer->stop();
   updatePauseButtonIcon();
 }
 
 void Animate::on_pauseButton_pressed()
 {
-  if (animate_timer->isActive()) {
-    animate_timer->stop();
+    if (animateTimer->isActive()) {
+        animateTimer->stop();
     updatePauseButtonIcon();
   } else {
     this->updatedAnimFpsAndAnimSteps();
@@ -195,11 +195,11 @@ void Animate::on_pauseButton_pressed()
 
 void Animate::updatePauseButtonIcon()
 {
-  if (animate_timer->isActive()) {
+    if (animateTimer->isActive()) {
     pauseButton->setIcon(this->iconPause);
     pauseButton->setToolTip(_("press to pause animation") );
   } else {
-    if (this->fps_ok && this->steps_ok) {
+    if (this->fpsOK && this->steps_ok) {
       pauseButton->setIcon(this->iconRun);
       pauseButton->setToolTip(_("press to start animation") );
     } else {
@@ -220,31 +220,31 @@ void Animate::editorContentChanged(){
 void Animate::animateUpdate()
 {
   if (mainWindow->animateDockContents->isVisible()) {
-    double fps = this->e_fps->text().toDouble(&this->fps_ok);
-    if (this->fps_ok && fps <= 0 && !animate_timer->isActive()) {
-      animate_timer->stop();
-      animate_timer->setSingleShot(true);
-      animate_timer->setInterval(50);
-      animate_timer->start();
+    double fps = this->e_fps->text().toDouble(&this->fpsOK);
+    if (this->fpsOK && fps <= 0 && !animateTimer->isActive()) {
+        animateTimer->stop();
+        animateTimer->setSingleShot(true);
+        animateTimer->setInterval(50);
+        animateTimer->start();
     }
   }
 }
 
 bool Animate::dumpPictures(){
-  return this->e_dump->isChecked() && this->animate_timer->isActive();
+    return this->e_dump->isChecked() && this->animateTimer->isActive();
 }
 
 int Animate::nextFrame(){
-  if (anim_dumping && anim_dump_start_step == anim_step) {
-    anim_dumping = false;
+    if (animDumping && animDumpStartStep == animStep) {
+        animDumping = false;
     e_dump->setChecked(false);
   } else {
-    if (!anim_dumping) {
-      anim_dumping = true;
-      anim_dump_start_step = anim_step;
+        if (!animDumping) {
+            animDumping = true;
+            animDumpStartStep = animStep;
     }
   }
-  return anim_step;
+    return animStep;
 }
 
 void Animate::resizeEvent(QResizeEvent *event)
@@ -272,44 +272,44 @@ void Animate::resizeEvent(QResizeEvent *event)
 }
 
 const QList<QAction *>& Animate::actions(){
-  return action_list;
+  return actionList;
 }
 
 void Animate::onActionEvent(InputEventAction *event)
 {
   const std::string actionString = event->action;
   const std::string actionName = actionString.substr(actionString.find("::") + 2, std::string::npos);
-  for (auto action : action_list) {
+  for (auto action : actionList) {
     if (actionName == action->objectName().toStdString()) {
       action->trigger();
     }
   }
 }
 
-double Animate::getAnim_tval(){
-  return anim_tval;
+double Animate::getAnimTval(){
+  return animTVal;
 }
 
 void Animate::on_pushButton_MoveToBeginning_clicked(){
   pauseAnimation();
-  this->anim_step = 0;
+  this->animStep = 0;
   this->updateTVal();
 }
 
 void Animate::on_pushButton_StepBack_clicked(){
   pauseAnimation();
-  this->anim_step -= 1;
+  this->animStep -= 1;
   this->updateTVal();
 }
 
 void Animate::on_pushButton_StepForward_clicked(){
   pauseAnimation();
-  this->anim_step += 1;
+  this->animStep += 1;
   this->updateTVal();
 }
 
 void Animate::on_pushButton_MoveToEnd_clicked(){
   pauseAnimation();
-  this->anim_step = this->anim_numsteps - 1;
+  this->animStep = this->animNumSteps - 1;
   this->updateTVal();
 }

src/gui/Animate.h

@@ -31,12 +31,12 @@ class Animate : public QWidget, public Ui::AnimateWidget
   bool dumpPictures();
   int nextFrame();
 
-  QTimer *animate_timer;
+  QTimer *animateTimer;
 
   void setMainWindow(MainWindow *mainWindow);
 
   const QList<QAction *>& actions();
-  double getAnim_tval();
+  double getAnimTval();
 
 public slots:
   void animateUpdate();
@@ -60,22 +60,22 @@ public slots:
   void updatePauseButtonIcon();
   void connectAction(QAction *, QPushButton *);
 
-  double anim_tval;
-  bool anim_dumping;
-  int anim_dump_start_step;
-  int anim_step;
-  int anim_numsteps;
+  double animTVal;
+  bool animDumping;
+  int animDumpStartStep;
+  int animStep;
+  int animNumSteps;
 
-  bool fps_ok;
-  bool t_ok;
+  bool fpsOK;
+  bool tOK;
   bool steps_ok;
 
   int initMinWidth;
 
   QIcon iconRun;
   QIcon iconPause;
   QIcon iconDisabled;
-  QList<QAction *> action_list;
+  QList<QAction *> actionList;
   QColor errorBlendColor{"red"};
 
 signals: