Skip to content

Commit 180f0b9

Browse files
nicocopybara-github
authored andcommitted
Roll libc++ from 25731e23e3aa to 91c45fc28459 (2 revisions)
The string_view nodiscard change requires updating absl_hardening_test.cc with a few "unused result" warning suppressions. Since that's a downstream file, we can just change the file. https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/25731e23e3aa..91c45fc28459 2025-11-24 [email protected] [libcxx] [test] Fix the gets-removed.verify.cpp test with Clang 21 (#169235) 2025-11-24 [email protected] [libc++][string_view] Applied `[[nodiscard]]` (#169010) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/libcxx-chromium Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Change-Id: Ia9bb68516c2f46f76bfd639941c81b3ab13b4f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201143 Reviewed-by: Hans Wennborg <[email protected]> Commit-Queue: Nico Weber <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#1551059} NOKEYCHECK=True GitOrigin-RevId: 3a229aacd71ba47d349c5bc99f4abab9d4a9a3c9
1 parent d65ddfa commit 180f0b9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

deps_revisions.gni

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
declare_args() {
66
# Used to cause full rebuilds on libc++ rolls. This should be kept in sync
77
# with the libcxx_revision var in //DEPS.
8-
libcxx_revision = "25731e23e3aae8f833705d3b2e6540d7d5eab3e0"
8+
libcxx_revision = "91c45fc28459e814889633be985b698c5e8050b4"
99
}

third_party/libc++/libcxx_headers.gni

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import("//buildtools/deps_revisions.gni")
1212

1313
assert(
14-
libcxx_revision == "25731e23e3aae8f833705d3b2e6540d7d5eab3e0",
14+
libcxx_revision == "91c45fc28459e814889633be985b698c5e8050b4",
1515
"libcxx_headers.gni and third_party/libc++ are out of sync.$0x0A$0x0AIf you were messing around with the libc++ repository, run:$0x0A`buildtools/third_party/libc++/generate_libcxx_headers.py`$0x0A$0x0AIf the script doesn't resolve the error, file a bug to msta@ with reproduction details.$0x0A")
1616

1717
libcxx_headers = [

0 commit comments

Comments
 (0)