Skip to content

Commit dce370f

Browse files
dumbmoroncopybara-github
authored andcommitted
[buildtools] Remove unrar exception from checkdeps/cpp_checker
Since the offending characters have been removed from unrar sources, this exception is no longer relevant and can be removed. Fixed: 458409084 Change-Id: Ibb9b67416ebb74387620ddfd6af7e5d27bfc2463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7180940 Reviewed-by: Daniel Rubery <[email protected]> Commit-Queue: Nico Weber <[email protected]> Reviewed-by: Nico Weber <[email protected]> Cr-Commit-Position: refs/heads/main@{#1548454} NOKEYCHECK=True GitOrigin-RevId: d9afc9227bb52a586c7719a85a241664405942d4
1 parent 1f926da commit dce370f

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

checkdeps/cpp_checker.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,8 @@ def CheckFile(self, rules, filepath):
8686
dependee_status = results.DependeeStatus(filepath)
8787
ret_val = '' # We'll collect the error messages in here
8888
last_include = 0
89-
encoding = 'utf-8'
9089

91-
# TODO(crbug.com/458409084): This can be removed once unrar sources are UTF8
92-
dir_path = os.path.relpath(os.path.dirname(filepath), self._root_dir)
93-
if dir_path.startswith(os.path.join('third_party', 'unrar') + os.sep):
94-
encoding = 'latin-1'
95-
96-
with open(filepath, encoding=encoding) as f:
90+
with open(filepath, encoding='utf-8') as f:
9791
in_if0 = 0
9892
for line_num, line in enumerate(f):
9993
line = line.strip()

0 commit comments

Comments
 (0)