Skip to content

Commit 7769a6d

Browse files
pcarletonlocalden
andauthored
Apply suggestions from code review, ty Den
Co-authored-by: Den Delimarsky 🌺 <[email protected]>
1 parent 30796d0 commit 7769a6d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

docs/specification/draft/basic/authorization.mdx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ Authorization servers **SHOULD** only automatically redirect the user agent if i
299299

300300
### 3.4 Confused Deputy Problem
301301

302-
An attacker can exploit configurations where an MCP server operates as a proxy in front of a third party resource server, leading to the confused deputy problem.
302+
An attacker can exploit configurations where an MCP server operates as a proxy in front of another resource server, leading to the confused deputy problem.
303303

304304
#### 3.4.1 Terminology
305305

@@ -376,13 +376,14 @@ attack becomes possible:
376376
indicating consent for the static client ID
377377
3. An attacker later sends the user a malicious link containing a crafted authorization request
378378
4. When the user clicks the link, their browser still has the consent cookie from the previous legitimate request
379-
5. The third-party authorization server sees the cookie and skips the consent screen
379+
5. The third-party authorization server detects the cookie and skips the consent screen
380380
6. The MCP authorization code is redirected to the attacker's server (specified in the crafted redirect_uri during dynamic client registration)
381-
7. The attacker exchanges the stolen authorization code for access tokens without the user's explicit approval
381+
7. The attacker exchanges the stolen authorization code for access tokens for the MCP server without the user's explicit approval
382+
8. Attacker now has access to the third-party API as the compromised user
382383

383384
#### 3.4.4 Mitigation
384385

385386
MCP proxy servers that use a static client ID for third-party services MUST require explicit
386-
approval for each newly registered dynamic client before forwarding requests to the
387+
approval for each dynamically registered client before forwarding requests to the
387388
third-party authorization server for user consent. This ensures that each MCP client's
388389
access is explicitly controlled at the proxy level.

0 commit comments

Comments
 (0)