Skip to content

Commit d3858ba

Browse files
author
Really Him
committed
fix: revise language; add mintlify broken-links npm script
1 parent 05b499c commit d3858ba

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

CONTRIBUTING.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ npm install # install dependencies
3232

3333
## Making Changes
3434

35-
Note that schema changes are made to `schema.ts`. `schema.json` is generated from
36-
`schema.ts` using `npm run generate:json`. You should validate your `schema.ts` changes
37-
by running `npm run validate:schema`.
35+
Note that schema changes are made to `schema.ts`, and `schema.json` is generated from
36+
`schema.ts`. You should validate your `schema.ts` changes first and then generate the
37+
`schema.json`.
3838

3939
1. Create a new branch:
4040

@@ -47,16 +47,21 @@ git checkout -b feature/your-feature-name
4747

4848
```bash
4949
npm run validate:schema # validate schema
50-
npm run generate:json # generate JSON schema
5150
```
5251

53-
4. Run docs locally (optional):
52+
4. Generate the `schema.json`:
53+
54+
```bash
55+
npm run generate:json # generate JSON schema
56+
```
57+
58+
5. Run docs locally (optional):
5459

5560
```bash
5661
npm run serve:docs
5762
```
5863

59-
5. Format/lint your changes:
64+
6. Format/lint your changes:
6065

6166
```bash
6267
npm run format:check # check formatting
@@ -72,10 +77,11 @@ When contributing to the documentation:
7277
- Include code examples where appropriate
7378
- Use proper MDX formatting and components
7479
- Test all links and code samples
80+
- You may run `npm run check-links` to look for broken internal links.
7581
- Use appropriate headings: "When to use", "Steps", and "Tips" for tutorials
7682
- Place new pages in appropriate sections (concepts, tutorials, etc.)
77-
- Update docs.json when adding new pages
78-
- Follow existing file naming conventions (kebab-case.mdx)
83+
- Update `docs.json` when adding new pages
84+
- Follow existing file naming conventions (`kebab-case.mdx`)
7985
- Include proper frontmatter in MDX files
8086

8187
### Specification Proposal Guidelines

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
"generate:json": "for f in schema/*/schema.ts; do typescript-json-schema --defaultNumberType integer --required --skipLibCheck \"$f\" \"*\" -o \"${f%ts}json\"; done",
2727
"serve:docs": "cd docs && mintlify dev",
2828
"format": "prettier --write \"**/*.md\"",
29-
"format:check": "prettier --check \"**/*.md\""
29+
"format:check": "prettier --check \"**/*.md\"",
30+
"check-links": "cd docs && mintlify broken-links"
3031
},
3132
"devDependencies": {
3233
"ajv": "^8.17.1",

0 commit comments

Comments
 (0)