Skip to content

Commit e702f52

Browse files
authored
Merge pull request modelcontextprotocol#606 from hesreallyhim/hesreallyhim/docs-small-fix-to-contributing-doc
docs: small fix to contributing doc
2 parents bb16bc8 + 02fc9ae commit e702f52

File tree

2 files changed

+22
-7
lines changed

2 files changed

+22
-7
lines changed

CONTRIBUTING.md

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@ npm install # install dependencies
3232

3333
## Making Changes
3434

35-
Note that schema changes are made to `schema.ts`. `schema.json` is generated from
36-
`schema.ts` using `npm run validate:schema`.
35+
Note that schema changes are made to `schema.ts`, and `schema.json` is generated from
36+
`schema.ts`. You should validate your `schema.ts` changes first and then generate the
37+
`schema.json`.
3738

3839
1. Create a new branch:
3940

@@ -46,15 +47,27 @@ git checkout -b feature/your-feature-name
4647

4748
```bash
4849
npm run validate:schema # validate schema
49-
npm run generate:json # generate JSON schema
5050
```
5151

52-
4. Run docs locally (optional):
52+
4. Generate the `schema.json`:
53+
54+
```bash
55+
npm run generate:json # generate JSON schema
56+
```
57+
58+
5. Run docs locally (optional):
5359

5460
```bash
5561
npm run serve:docs
5662
```
5763

64+
6. Format/lint your changes:
65+
66+
```bash
67+
npm run format:check # check formatting
68+
npm run format # apply formatting
69+
```
70+
5871
### Documentation Guidelines
5972

6073
When contributing to the documentation:
@@ -64,10 +77,11 @@ When contributing to the documentation:
6477
- Include code examples where appropriate
6578
- Use proper MDX formatting and components
6679
- Test all links and code samples
80+
- You may run `npm run check-links` to look for broken internal links.
6781
- Use appropriate headings: "When to use", "Steps", and "Tips" for tutorials
6882
- Place new pages in appropriate sections (concepts, tutorials, etc.)
69-
- Update docs.json when adding new pages
70-
- Follow existing file naming conventions (kebab-case.mdx)
83+
- Update `docs.json` when adding new pages
84+
- Follow existing file naming conventions (`kebab-case.mdx`)
7185
- Include proper frontmatter in MDX files
7286

7387
### Specification Proposal Guidelines

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@
2626
"generate:json": "for f in schema/*/schema.ts; do typescript-json-schema --defaultNumberType integer --required --skipLibCheck \"$f\" \"*\" -o \"${f%ts}json\"; done",
2727
"serve:docs": "cd docs && mintlify dev",
2828
"format": "prettier --write \"**/*.md\"",
29-
"format:check": "prettier --check \"**/*.md\""
29+
"format:check": "prettier --check \"**/*.md\"",
30+
"check-links": "cd docs && mintlify broken-links"
3031
},
3132
"devDependencies": {
3233
"ajv": "^8.17.1",

0 commit comments

Comments
 (0)