Skip to content

remove unused MIDDLEWARE_CLASSES, improve settings/dev.py comments #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove unused MIDDLEWARE_CLASSES, improve settings/dev.py comments #55

wants to merge 1 commit into from

Conversation

pawl
Copy link
Contributor

@pawl pawl commented Apr 18, 2020

This PR makes some improvements to settings/dev.py:

  • You don't need whitenoise middleware defined in both MIDDLEWARE_CLASSES and MIDDLEWARE for recent versions of django. So I removed the MIDDLEWARE_CLASSES.
  • Moved the comment about the whitenoise middleware to the relevant spot.
  • Removed # STATIC # comment that was in the wrong place.
  • Added some additional comments with links to docs and clarifications

samangolestani
samangolestani suggested changes Aug 24, 2021
View reviewed changes
Copy link

@samangolestani samangolestani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KOSG
OO23O0 RE
-GRP SHA O IAPOPOPO [p [p[sp[p][g]][4 ][][]][2 ]]s]-043-0- S OO O OPAG
S
POPRGA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@samangolestani samangolestani samangolestani requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawl @samangolestani