SKProductsRequest as class level variable

gtebbutt · gtebbutt · commit ca5b389d2306 · 2017-11-27T14:09:31.000Z
Needs improvement; see chirag04#48
diff --git a/InAppUtils/InAppUtils.m b/InAppUtils/InAppUtils.m
@@ -8,6 +8,7 @@ @implementation InAppUtils
 {
     NSArray *products;
     NSMutableDictionary *_callbacks;
+    SKProductsRequest *request;
 }
 
 - (instancetype)init
@@ -191,11 +192,10 @@ - (void)paymentQueueRestoreCompletedTransactionsFinished:(SKPaymentQueue *)queue
 RCT_EXPORT_METHOD(loadProducts:(NSArray *)productIdentifiers
                   callback:(RCTResponseSenderBlock)callback)
 {
-    SKProductsRequest *productsRequest = [[SKProductsRequest alloc]
-                                          initWithProductIdentifiers:[NSSet setWithArray:productIdentifiers]];
-    productsRequest.delegate = self;
-    _callbacks[RCTKeyForInstance(productsRequest)] = callback;
-    [productsRequest start];
+    request = [[SKProductsRequest alloc] initWithProductIdentifiers:[NSSet setWithArray:productIdentifiers]];
+    request.delegate = self;
+    _callbacks[RCTKeyForInstance(request)] = callback;
+    [request start];
 }
 
 RCT_EXPORT_METHOD(canMakePayments: (RCTResponseSenderBlock)callback)

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ @implementation InAppUtils`
`8`	`8`	`{`
`9`	`9`	`NSArray *products;`
`10`	`10`	`NSMutableDictionary *_callbacks;`
	`11`	`+ SKProductsRequest *request;`
`11`	`12`	`}`
`12`	`13`
`13`	`14`	`- (instancetype)init`
`@@ -191,11 +192,10 @@ - (void)paymentQueueRestoreCompletedTransactionsFinished:(SKPaymentQueue *)queue`
`191`	`192`	`RCT_EXPORT_METHOD(loadProducts:(NSArray *)productIdentifiers`
`192`	`193`	`callback:(RCTResponseSenderBlock)callback)`
`193`	`194`	`{`
`194`		`- SKProductsRequest *productsRequest = [[SKProductsRequest alloc]`
`195`		`- initWithProductIdentifiers:[NSSet setWithArray:productIdentifiers]];`
`196`		`- productsRequest.delegate = self;`
`197`		`- _callbacks[RCTKeyForInstance(productsRequest)] = callback;`
`198`		`- [productsRequest start];`
	`195`	`+ request = [[SKProductsRequest alloc] initWithProductIdentifiers:[NSSet setWithArray:productIdentifiers]];`
	`196`	`+ request.delegate = self;`
	`197`	`+ _callbacks[RCTKeyForInstance(request)] = callback;`
	`198`	`+ [request start];`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`RCT_EXPORT_METHOD(canMakePayments: (RCTResponseSenderBlock)callback)`