feat(cli): Interactive cloud connection (#532)

When user has not specified `--os-cloud` param but the cli is running in
an interactive mode we can invoke dialoguer to offer user configured
clouds to select (similarly how it is done in the tui).

Author: gtema

Cargo.lock

@@ -47,7 +47,7 @@ clap = { workspace = true, features = ["color", "derive", "env"] }
 clap_complete = { workspace = true }
 cli-table = "^0.4"
 color-eyre = { workspace = true }
-dialoguer = {workspace = true}
+dialoguer = { workspace = true, features=["fuzzy-select"] }
 eyre = { version = "^0.6" }
 http = { workspace = true }
 human-panic = { workspace = true }

openstack_cli/Cargo.toml

@@ -147,6 +147,14 @@ pub enum OpenStackCliError {
         source: http::header::InvalidHeaderValue,
     },
 
+    /// User interaction using dialoguer crate failed
+    #[error("dialoguer error `{}`", source)]
+    DialoguerError {
+        /// The source of the error.
+        #[from]
+        source: dialoguer::Error,
+    },
+
     /// Others.
     #[error(transparent)]
     Other(#[from] eyre::Report),

openstack_cli/src/error.rs

@@ -25,7 +25,8 @@ use std::io::{self, IsTerminal};
 
 use clap::{CommandFactory, Parser};
 use clap_complete::generate;
-use eyre::OptionExt;
+use dialoguer::FuzzySelect;
+use eyre::eyre;
 use tracing::{warn, Level};
 
 use openstack_sdk::{
@@ -81,16 +82,30 @@ pub async fn entry_point() -> Result<(), OpenStackCliError> {
         .init();
 
     let cfg = openstack_sdk::config::ConfigFile::new().unwrap();
+    // Identify target cloud to connect to
+    let cloud_name = match cli.global_opts.os_cloud {
+        Some(ref cloud) => cloud.clone(),
+        None => {
+            if std::io::stdin().is_terminal() {
+                // Cloud was not selected and we are in the potentially interactive mode (terminal)
+                let mut profiles = cfg.get_available_clouds();
+                profiles.sort();
+                let selected_cloud_idx = FuzzySelect::new()
+                    .with_prompt("Please select cloud you want to connect to (use `--os-cloud` next time for efficiency)?")
+                    .items(&profiles)
+                    .interact()?;
+                profiles[selected_cloud_idx].clone()
+            } else {
+                return Err(
+                    eyre!("`--os-cloud` or `OS_CLOUD` environment variable must be given").into(),
+                );
+            }
+        }
+    };
+    // Get the connection details
     let profile = cfg
-        .get_cloud_config(
-            cli.global_opts
-                .os_cloud
-                .clone()
-                .ok_or_eyre("`--os-cloud` or `OS_CLOUD` environment variable must be given")?,
-        )?
-        .ok_or(OpenStackCliError::ConnectionNotFound(
-            cli.global_opts.os_cloud.clone().unwrap(),
-        ))?;
+        .get_cloud_config(&cloud_name)?
+        .ok_or(OpenStackCliError::ConnectionNotFound(cloud_name))?;
     let mut renew_auth: bool = false;
 
     // Login command need to be analyzed before authorization
@@ -104,10 +119,12 @@ pub async fn entry_point() -> Result<(), OpenStackCliError> {
 
     let mut session;
     if std::io::stdin().is_terminal() {
+        // Interactive session (may ask for password/MFA/SSO)
         session = AsyncOpenStack::new_interactive(&profile, renew_auth)
             .await
             .map_err(|err| OpenStackCliError::Auth { source: err })?;
     } else {
+        // Non-interactive session if i.e. scripted with chaining
         session = AsyncOpenStack::new(&profile)
             .await
             .map_err(|err| OpenStackCliError::Auth { source: err })?;

openstack_cli/src/lib.rs

@@ -385,9 +385,12 @@ impl ConfigFile {
     ///
     /// This method does not raise the exception when the cloud is
     /// not found.
-    pub fn get_cloud_config(&self, cloud_name: String) -> Result<Option<CloudConfig>, ConfigError> {
+    pub fn get_cloud_config<S: AsRef<str>>(
+        &self,
+        cloud_name: S,
+    ) -> Result<Option<CloudConfig>, ConfigError> {
         if let Some(clouds) = &self.clouds {
-            if let Some(cfg) = clouds.get(&cloud_name) {
+            if let Some(cfg) = clouds.get(cloud_name.as_ref()) {
                 let mut config = cfg.clone();
                 if let Some(ref profile_name) = config.profile {
                     let mut profile_definition: Option<&CloudConfig> = None;