chore: Address new clippy complains (#1568)

Author: gtema

openstack_cli/src/error.rs

@@ -195,6 +195,14 @@ pub enum OpenStackCliError {
     #[error("valid authentication is missing to be able to rescope the session")]
     MissingValidAuthenticationForRescope,
 
+    /// URL parsing error
+    #[error(transparent)]
+    UrlParse {
+        /// The source of the error.
+        #[from]
+        source: url::ParseError,
+    },
+
     /// Others.
     #[error(transparent)]
     Other(#[from] eyre::Report),

openstack_cli/src/identity/v4/user/passkey/register.rs

@@ -524,7 +524,7 @@ impl PasskeyCommand {
             webauthn_authenticator_rs::mozilla::MozillaAuthenticator::new(),
         );
         match auth.do_registration(
-            Url::parse("http://localhost:8080").unwrap(),
+            Url::parse("http://localhost:8080")?,
             convert_api_parameters_to_webauthn(pk_request)?,
         ) {
             Ok(rsp) => {

openstack_cli/src/object_store/v1/account/set.rs

@@ -99,8 +99,7 @@ impl AccountCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back();
+            .rfind(|x| !x.is_empty());
         if let Some(account) = account {
             ep_builder.account(account);
         }

openstack_cli/src/object_store/v1/account/show.rs

@@ -71,8 +71,7 @@ impl AccountCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back();
+            .rfind(|x| !x.is_empty());
         if let Some(account) = account {
             ep_builder.account(account);
         }

openstack_cli/src/object_store/v1/container/create.rs

@@ -78,8 +78,7 @@ impl ContainerCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back();
+            .rfind(|x| !x.is_empty());
         if let Some(account) = account {
             ep_builder.account(account);
         }

openstack_cli/src/object_store/v1/container/delete.rs

@@ -78,8 +78,7 @@ impl ContainerCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back();
+            .rfind(|x| !x.is_empty());
         if let Some(account) = account {
             ep_builder.account(account);
         }

openstack_cli/src/object_store/v1/container/list.rs

@@ -128,8 +128,7 @@ impl ContainersCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back();
+            .rfind(|x| !x.is_empty());
         if let Some(account) = account {
             ep_builder.account(account);
         }

openstack_cli/src/object_store/v1/container/prune.rs

@@ -66,8 +66,7 @@ impl ContainerCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back()
+            .rfind(|x| !x.is_empty())
             .ok_or_else(|| eyre!("Object Store endpoint must end with project id"))?;
         client
             .object_store_container_prune_async(account, &self.container, self.prefix.as_ref())

openstack_cli/src/object_store/v1/container/set.rs

@@ -78,8 +78,7 @@ impl ContainerCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back();
+            .rfind(|x| !x.is_empty());
         if let Some(account) = account {
             ep_builder.account(account);
         }

openstack_cli/src/object_store/v1/container/show.rs

@@ -73,8 +73,7 @@ impl ContainerCommand {
             .url()
             .path_segments()
             .ok_or_else(|| eyre!("Object Store endpoint must not point to a bare domain"))?
-            .filter(|x| !x.is_empty())
-            .next_back();
+            .rfind(|x| !x.is_empty());
         if let Some(account) = account {
             ep_builder.account(account);
         }