fix clippy warnings

Author: jgcodes2020

graphene/src/matrix.rs

@@ -234,7 +234,7 @@ impl ops::Mul<Matrix> for Matrix {
     type Output = Matrix;
 
     fn mul(self, rhs: Matrix) -> Self::Output {
-        (&self).multiply(&rhs)
+        Matrix::multiply(&self, &rhs)
     }
 }
 impl ops::MulAssign<Matrix> for Matrix {
@@ -246,32 +246,38 @@ impl ops::MulAssign<Matrix> for Matrix {
 impl ops::Mul<Vec4> for Matrix {
     type Output = Vec4;
 
+    /// Transforms this `Vec4` using the provided matrix.
+    /// See [Matrix::transform_vec4].
     fn mul(self, rhs: Vec4) -> Self::Output {
-        (&self).transform_vec4(&rhs)
+        Matrix::transform_vec4(&self, &rhs)
     }
 }
 
 impl ops::Mul<Vec3> for Matrix {
     type Output = Vec3;
 
+    /// Transforms this `Vec3` using the provided matrix.
+    /// See [Matrix::transform_vec3].
     fn mul(self, rhs: Vec3) -> Self::Output {
-        (&self).transform_vec3(&rhs)
+        Matrix::transform_vec3(&self, &rhs)
     }
 }
 
 impl ops::Mul<Point> for Matrix {
     type Output = Point;
 
     fn mul(self, rhs: Point) -> Self::Output {
-        (&self).transform_point(&rhs)
+        Matrix::transform_point(&self, &rhs)
     }
 }
 
 impl ops::Mul<Point3D> for Matrix {
     type Output = Point3D;
 
+    /// Transforms this point using the provided matrix.
+    /// See [Matrix::transform_point3d].
     fn mul(self, rhs: Point3D) -> Self::Output {
-        (&self).transform_point3d(&rhs)
+        Matrix::transform_point3d(&self, &rhs)
     }
 }
 

graphene/src/quaternion.rs

@@ -150,7 +150,7 @@ impl ops::Add<Quaternion> for Quaternion {
     type Output = Quaternion;
 
     fn add(self, rhs: Quaternion) -> Self::Output {
-        (&self).add(&rhs)
+        Quaternion::add(&self, &rhs)
     }
 }
 
@@ -164,7 +164,7 @@ impl ops::Mul<Quaternion> for Quaternion {
     type Output = Quaternion;
 
     fn mul(self, rhs: Quaternion) -> Self::Output {
-        (&self).multiply(&rhs)
+        Quaternion::multiply(&self, &rhs)
     }
 }
 

graphene/src/vec2.rs

@@ -58,7 +58,7 @@ impl ops::Add<Vec2> for Vec2 {
     type Output = Vec2;
 
     fn add(self, rhs: Vec2) -> Self::Output {
-        (&self).add(&rhs)
+        Vec2::add(&self, &rhs)
     }
 }
 impl ops::AddAssign<Vec2> for Vec2 {
@@ -70,7 +70,7 @@ impl ops::Sub<Vec2> for Vec2 {
     type Output = Vec2;
 
     fn sub(self, rhs: Vec2) -> Self::Output {
-        (&self).subtract(&rhs)
+        Vec2::subtract(&self, &rhs)
     }
 }
 impl ops::SubAssign<Vec2> for Vec2 {
@@ -82,7 +82,7 @@ impl ops::Neg for Vec2 {
     type Output = Vec2;
 
     fn neg(self) -> Self::Output {
-        (&self).negate()
+        Vec2::negate(&self)
     }
 }
 
@@ -91,7 +91,7 @@ impl ops::Mul<f32> for Vec2 {
     type Output = Vec2;
 
     fn mul(self, rhs: f32) -> Self::Output {
-        (&self).scale(rhs)
+        Vec2::scale(&self, rhs)
     }
 }
 impl ops::MulAssign<f32> for Vec2 {
@@ -112,7 +112,7 @@ impl ops::Mul<Vec2> for Vec2 {
     type Output = Vec2;
 
     fn mul(self, rhs: Vec2) -> Self::Output {
-        (&self).multiply(&rhs)
+        Vec2::multiply(&self, &rhs)
     }
 }
 impl ops::MulAssign<Vec2> for Vec2 {
@@ -124,7 +124,7 @@ impl ops::Div<Vec2> for Vec2 {
     type Output = Vec2;
 
     fn div(self, rhs: Vec2) -> Self::Output {
-        (&self).divide(&rhs)
+        Vec2::divide(&self, &rhs)
     }
 }
 impl ops::DivAssign<Vec2> for Vec2 {

graphene/src/vec3.rs

@@ -59,7 +59,7 @@ impl ops::Add<Vec3> for Vec3 {
     type Output = Vec3;
 
     fn add(self, rhs: Vec3) -> Self::Output {
-        (&self).add(&rhs)
+        Vec3::add(&self, &rhs)
     }
 }
 impl ops::AddAssign<Vec3> for Vec3 {
@@ -71,7 +71,7 @@ impl ops::Sub<Vec3> for Vec3 {
     type Output = Vec3;
 
     fn sub(self, rhs: Vec3) -> Self::Output {
-        (&self).subtract(&rhs)
+        Vec3::subtract(&self, &rhs)
     }
 }
 impl ops::SubAssign<Vec3> for Vec3 {
@@ -83,7 +83,7 @@ impl ops::Neg for Vec3 {
     type Output = Vec3;
 
     fn neg(self) -> Self::Output {
-        (&self).negate()
+        Vec3::negate(&self)
     }
 }
 
@@ -92,7 +92,7 @@ impl ops::Mul<f32> for Vec3 {
     type Output = Vec3;
 
     fn mul(self, rhs: f32) -> Self::Output {
-        (&self).scale(rhs)
+        Vec3::scale(&self, rhs)
     }
 }
 impl ops::MulAssign<f32> for Vec3 {
@@ -113,7 +113,7 @@ impl ops::Mul<Vec3> for Vec3 {
     type Output = Vec3;
 
     fn mul(self, rhs: Vec3) -> Self::Output {
-        (&self).multiply(&rhs)
+        Vec3::multiply(&self, &rhs)
     }
 }
 impl ops::MulAssign<Vec3> for Vec3 {
@@ -125,7 +125,7 @@ impl ops::Div<Vec3> for Vec3 {
     type Output = Vec3;
 
     fn div(self, rhs: Vec3) -> Self::Output {
-        (&self).divide(&rhs)
+        Vec3::divide(&self, &rhs)
     }
 }
 impl ops::DivAssign<Vec3> for Vec3 {

graphene/src/vec4.rs

@@ -82,7 +82,7 @@ impl ops::Add<Vec4> for Vec4 {
     type Output = Vec4;
 
     fn add(self, rhs: Vec4) -> Self::Output {
-        (&self).add(&rhs)
+        Vec4::add(&self, &rhs)
     }
 }
 impl ops::AddAssign<Vec4> for Vec4 {
@@ -94,7 +94,7 @@ impl ops::Sub<Vec4> for Vec4 {
     type Output = Vec4;
 
     fn sub(self, rhs: Vec4) -> Self::Output {
-        (&self).subtract(&rhs)
+        Vec4::subtract(&self, &rhs)
     }
 }
 impl ops::SubAssign<Vec4> for Vec4 {
@@ -106,7 +106,7 @@ impl ops::Neg for Vec4 {
     type Output = Vec4;
 
     fn neg(self) -> Self::Output {
-        (&self).negate()
+        Vec4::negate(&self)
     }
 }
 
@@ -115,7 +115,7 @@ impl ops::Mul<f32> for Vec4 {
     type Output = Vec4;
 
     fn mul(self, rhs: f32) -> Self::Output {
-        (&self).scale(rhs)
+        Vec4::scale(&self, rhs)
     }
 }
 impl ops::MulAssign<f32> for Vec4 {
@@ -136,7 +136,7 @@ impl ops::Mul<Vec4> for Vec4 {
     type Output = Vec4;
 
     fn mul(self, rhs: Vec4) -> Self::Output {
-        (&self).multiply(&rhs)
+        Vec4::multiply(&self, &rhs)
     }
 }
 impl ops::MulAssign<Vec4> for Vec4 {
@@ -148,7 +148,7 @@ impl ops::Div<Vec4> for Vec4 {
     type Output = Vec4;
 
     fn div(self, rhs: Vec4) -> Self::Output {
-        (&self).divide(&rhs)
+        Vec4::divide(&self, &rhs)
     }
 }
 impl ops::DivAssign<Vec4> for Vec4 {