Skip to content

Commit 3e24857

Browse files
Renyi Zhaosdroege
authored andcommitted
glib: Fix UB in spawn_async_with_pipes by validating success before assume_init
1 parent cbc15b8 commit 3e24857

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

glib/src/functions.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,11 @@ pub fn spawn_async_with_pipes<
179179
standard_error.as_mut_ptr(),
180180
&mut error,
181181
);
182-
let child_pid = from_glib(child_pid.assume_init());
183-
let standard_input = standard_input.assume_init();
184-
let standard_output = standard_output.assume_init();
185-
let standard_error = standard_error.assume_init();
186182
if error.is_null() {
183+
let child_pid = from_glib(child_pid.assume_init());
184+
let standard_input = standard_input.assume_init();
185+
let standard_output = standard_output.assume_init();
186+
let standard_error = standard_error.assume_init();
187187
#[cfg(not(windows))]
188188
{
189189
Ok((

0 commit comments

Comments
 (0)