glib: Deprecate suboptimal Object constructors

Author: sdroege

gio/src/async_initable.rs

@@ -16,6 +16,8 @@ impl AsyncInitable {
     #[allow(clippy::new_ret_no_self)]
     #[doc(alias = "g_async_initable_new_async")]
     #[track_caller]
+    #[deprecated = "Use AsyncInitable::builder() or AsyncInitable::new_default() instead"]
+    #[allow(deprecated)]
     pub fn new<
         O: IsClass + IsA<Object> + IsA<AsyncInitable>,
         Q: FnOnce(Result<O, glib::Error>) + 'static,
@@ -41,6 +43,8 @@ impl AsyncInitable {
     /// `AsyncInitable::init` failed.
     #[doc(alias = "g_async_initable_new_async")]
     #[track_caller]
+    #[deprecated = "Use AsyncInitable::builder() or AsyncInitable::new_default_future() instead"]
+    #[allow(deprecated)]
     pub fn new_future<O: IsClass + IsA<Object> + IsA<AsyncInitable>>(
         properties: &[(&str, &dyn ToValue)],
         io_priority: glib::Priority,
@@ -58,6 +62,7 @@ impl AsyncInitable {
     /// `AsyncInitable::init` failed.
     #[doc(alias = "g_async_initable_new_async")]
     #[track_caller]
+    #[deprecated = "Use AsyncInitable::builder() or AsyncInitable::new_default_with_type() instead"]
     pub fn with_type<Q: FnOnce(Result<Object, glib::Error>) + 'static>(
         type_: Type,
         properties: &[(&str, &dyn ToValue)],
@@ -93,6 +98,7 @@ impl AsyncInitable {
     /// `AsyncInitable::init` failed.
     #[doc(alias = "g_async_initable_new_async")]
     #[track_caller]
+    #[deprecated = "Use AsyncInitable::builder() or AsyncInitable::new_default_future() instead"]
     pub fn with_type_future(
         type_: Type,
         properties: &[(&str, &dyn ToValue)],
@@ -230,6 +236,7 @@ impl AsyncInitable {
     /// `AsyncInitable::init` failed.
     #[doc(alias = "g_async_initable_new_async")]
     #[track_caller]
+    #[deprecated = "Use AsyncInitable::with_mut_values() instead"]
     pub fn with_values<Q: FnOnce(Result<Object, glib::Error>) + 'static>(
         type_: Type,
         properties: &[(&str, glib::Value)],
@@ -265,6 +272,7 @@ impl AsyncInitable {
     /// `AsyncInitable::init` failed.
     #[doc(alias = "g_async_initable_new_async")]
     #[track_caller]
+    #[deprecated = "Use AsyncInitable::with_mut_values_future() instead"]
     pub fn with_values_future(
         type_: Type,
         properties: &[(&str, glib::Value)],

gio/src/initable.rs

@@ -14,6 +14,8 @@ impl Initable {
     /// `Initable::init` failed.
     #[allow(clippy::new_ret_no_self)]
     #[track_caller]
+    #[deprecated = "Use Initable::builder() or Initable::new_default() instead"]
+    #[allow(deprecated)]
     pub fn new<O: IsClass + IsA<Object> + IsA<Initable>>(
         properties: &[(&str, &dyn ToValue)],
         cancellable: Option<&impl IsA<Cancellable>>,
@@ -28,6 +30,7 @@ impl Initable {
     /// Similar to [`Object::with_type`] but can fail because the object initialization in
     /// `Initable::init` failed.
     #[track_caller]
+    #[deprecated = "Use Initable::builder() or Initable::new_default_with_type() instead"]
     pub fn with_type(
         type_: Type,
         properties: &[(&str, &dyn ToValue)],
@@ -89,6 +92,7 @@ impl Initable {
     /// Similar to [`Object::with_values`] but can fail because the object initialization in
     /// `Initable::init` failed.
     #[track_caller]
+    #[deprecated = "Use Initable::with_mut_values() instead"]
     pub fn with_values(
         type_: Type,
         properties: &[(&str, glib::Value)],

glib/src/object.rs

@@ -1352,6 +1352,8 @@ impl Object {
     /// property values of the wrong type are provided.
     #[allow(clippy::new_ret_no_self)]
     #[track_caller]
+    #[deprecated = "Use Object::builder() or Object::new_default() instead"]
+    #[allow(deprecated)]
     pub fn new<T: IsA<Object> + IsClass>(properties: &[(&str, &dyn ToValue)]) -> T {
         let object = Object::with_type(T::static_type(), properties);
         unsafe { object.unsafe_cast() }
@@ -1365,6 +1367,7 @@ impl Object {
     /// This panics if the object is not instantiable, doesn't have all the given properties or
     /// property values of the wrong type are provided.
     #[track_caller]
+    #[deprecated = "Use Object::builder_with_type() or Object::new_default_with_type() instead"]
     pub fn with_type(type_: Type, properties: &[(&str, &dyn ToValue)]) -> Object {
         #[cfg(feature = "gio")]
         unsafe {
@@ -1412,11 +1415,15 @@ impl Object {
     // rustdoc-stripper-ignore-next
     /// Create a new instance of an object of the given type with the given properties.
     ///
+    /// If possible call [`with_mut_values`] instead as this function has to take copies of all
+    /// values before constructing the object.
+    ///
     /// # Panics
     ///
     /// This panics if the object is not instantiable, doesn't have all the given properties or
     /// property values of the wrong type are provided.
     #[track_caller]
+    #[deprecated = "Use Object::with_mut_values()` instead"]
     pub fn with_values(type_: Type, properties: &[(&str, Value)]) -> Object {
         #[cfg(feature = "gio")]
         unsafe {