Merge pull request #816 from GuillaumeGomez/fix-lints

Fix new clippy lints

Author: sdroege

cairo/src/paths.rs

@@ -102,7 +102,7 @@ impl<'a> Iterator for PathSegments<'a> {
                     to_tuple(&self.data[self.i + 3].point),
                 ),
                 PathDataType::ClosePath => PathSegment::ClosePath,
-                PathDataType::__Unknown(x) => panic!("Unknown value: {}", x),
+                PathDataType::__Unknown(x) => panic!("Unknown value: {x}"),
             };
 
             self.i += self.data[self.i].header.length as usize;

cairo/sys/build.rs

@@ -7,7 +7,7 @@ fn main() {} // prevent linking libraries to avoid documentation failure
 #[cfg(not(feature = "dox"))]
 fn main() {
     if let Err(s) = system_deps::Config::new().probe() {
-        println!("cargo:warning={}", s);
+        println!("cargo:warning={s}");
         process::exit(1);
     }
 }

examples/gio_cancellable_future/main.rs

@@ -27,7 +27,7 @@ fn main() {
         let cancellable_task = gio::CancellableFuture::new(a_very_long_task(), cancellable.clone())
             .map(move |res| {
                 if let Err(error) = res {
-                    println!("{:?}", error);
+                    println!("{error:?}");
                 }
 
                 main_loop.quit();

examples/gio_futures/main.rs

@@ -17,7 +17,7 @@ fn main() {
             // error first print that error.
             .map(move |res| {
                 if let Err(err) = res {
-                    eprintln!("Got error: {}", err);
+                    eprintln!("Got error: {err}");
                 }
 
                 l_clone.quit();
@@ -36,7 +36,7 @@ fn read_and_print_file(
     file: &gio::File,
 ) -> impl Future<Output = Result<(), String>> + std::marker::Unpin {
     file.read_future(glib::PRIORITY_DEFAULT)
-        .map_err(|err| format!("Failed to open file: {}", err))
+        .map_err(|err| format!("Failed to open file: {err}"))
         .and_then(read_and_print_chunks)
 }
 
@@ -98,9 +98,9 @@ fn read_and_print_next_chunk(
 ) -> impl Future<Output = Result<Option<Vec<u8>>, String>> + std::marker::Unpin {
     let strm_clone = strm.clone();
     strm.read_future(buf, glib::PRIORITY_DEFAULT)
-        .map_err(|(_buf, err)| format!("Failed to read from stream: {}", err))
+        .map_err(|(_buf, err)| format!("Failed to read from stream: {err}"))
         .and_then(move |(buf, len)| {
-            println!("line {}: {:?}", idx, str::from_utf8(&buf[0..len]).unwrap());
+            println!("line {idx}: {:?}", str::from_utf8(&buf[0..len]).unwrap());
 
             // 0 is only returned when the input stream is finished, in which case
             // we drop the buffer and close the stream asynchronously.
@@ -111,7 +111,7 @@ fn read_and_print_next_chunk(
                 futures::future::Either::Left(
                     strm_clone
                         .close_future(glib::PRIORITY_DEFAULT)
-                        .map_err(|err| format!("Failed to close stream: {}", err))
+                        .map_err(|err| format!("Failed to close stream: {err}"))
                         .map_ok(|_| None),
                 )
             } else {

examples/gio_futures_await/main.rs

@@ -14,7 +14,7 @@ fn main() {
     let future = clone!(@strong l => async move {
         match read_file(file).await {
             Ok(()) => (),
-            Err(err) => eprintln!("Got error: {}", err),
+            Err(err) => eprintln!("Got error: {err}"),
         }
         l.quit();
     });
@@ -30,7 +30,7 @@ async fn read_file(file: gio::File) -> Result<(), String> {
     // Try to open the file.
     let strm = file
         .read_future(glib::PRIORITY_DEFAULT)
-        .map_err(|err| format!("Failed to open file: {}", err))
+        .map_err(|err| format!("Failed to open file: {err}"))
         .await?;
 
     // If opening the file succeeds, we asynchronously loop and
@@ -42,7 +42,7 @@ async fn read_file(file: gio::File) -> Result<(), String> {
     loop {
         let (b, len) = strm
             .read_future(buf, glib::PRIORITY_DEFAULT)
-            .map_err(|(_buf, err)| format!("Failed to read from stream: {}", err))
+            .map_err(|(_buf, err)| format!("Failed to read from stream: {err}"))
             .await?;
 
         // Once 0 is returned, we know that we're done with reading, otherwise
@@ -53,14 +53,14 @@ async fn read_file(file: gio::File) -> Result<(), String> {
 
         buf = b;
 
-        println!("line {}: {:?}", idx, str::from_utf8(&buf[0..len]).unwrap());
+        println!("line {idx}: {:?}", str::from_utf8(&buf[0..len]).unwrap());
 
         idx += 1;
     }
 
     // Asynchronously close the stream in the end.
     strm.close_future(glib::PRIORITY_DEFAULT)
-        .map_err(|err| format!("Failed to close stream: {}", err))
+        .map_err(|err| format!("Failed to close stream: {err}"))
         .await?;
 
     Ok(())

examples/gio_task/main.rs

@@ -58,7 +58,7 @@ fn run_unsafe(send: oneshot::Sender<()>) {
             return;
         }
 
-        println!("Unsafe callback - Returned value from task: {}", ret);
+        println!("Unsafe callback - Returned value from task: {ret}");
         println!(
             "Unsafe callback - FileSize::size: {}",
             file_size::ffi::my_file_size_get_retrieved_size(
@@ -89,7 +89,7 @@ fn run_safe(send: oneshot::Sender<()>) {
     let cancellable = gio::Cancellable::new();
 
     let closure = move |value: i64, source_object: &FileSize| {
-        println!("Safe callback - Returned value from task: {}", value);
+        println!("Safe callback - Returned value from task: {value}");
         println!(
             "Safe callback - FileSize::size: {}",
             source_object.retrieved_size().unwrap()

gdk-pixbuf/src/auto/flags.rs

@@ -10,11 +10,11 @@ bitflags! {
     #[doc(alias = "GdkPixbufFormatFlags")]
     pub struct PixbufFormatFlags: u32 {
         #[doc(alias = "GDK_PIXBUF_FORMAT_WRITABLE")]
-        const WRITABLE = ffi::GDK_PIXBUF_FORMAT_WRITABLE as u32;
+        const WRITABLE = ffi::GDK_PIXBUF_FORMAT_WRITABLE as _;
         #[doc(alias = "GDK_PIXBUF_FORMAT_SCALABLE")]
-        const SCALABLE = ffi::GDK_PIXBUF_FORMAT_SCALABLE as u32;
+        const SCALABLE = ffi::GDK_PIXBUF_FORMAT_SCALABLE as _;
         #[doc(alias = "GDK_PIXBUF_FORMAT_THREADSAFE")]
-        const THREADSAFE = ffi::GDK_PIXBUF_FORMAT_THREADSAFE as u32;
+        const THREADSAFE = ffi::GDK_PIXBUF_FORMAT_THREADSAFE as _;
     }
 }
 

gdk-pixbuf/src/auto/pixbuf_loader.rs

@@ -154,7 +154,7 @@ impl<O: IsA<PixbufLoader>> PixbufLoaderExt for O {
     }
 
     fn write(&self, buf: &[u8]) -> Result<(), glib::Error> {
-        let count = buf.len() as usize;
+        let count = buf.len() as _;
         unsafe {
             let mut error = ptr::null_mut();
             let is_ok = ffi::gdk_pixbuf_loader_write(

gdk-pixbuf/src/auto/versions.txt

@@ -1,2 +1,2 @@
-Generated by gir (https://github.com/gtk-rs/gir @ 952ff416b599)
+Generated by gir (https://github.com/gtk-rs/gir @ 818f714dc796)
 from gir-files (https://github.com/gtk-rs/gir-files @ 89a11aa6a362)

gdk-pixbuf/src/pixbuf.rs

@@ -50,7 +50,7 @@ impl Pixbuf {
         let ptr = {
             let data: &mut [u8] = (*data).as_mut();
             assert!(
-                data.len() >= ((height - 1) * row_stride + last_row_len) as usize,
+                data.len() >= ((height - 1) * row_stride + last_row_len),
                 "data.len() must fit the width, height, and row_stride"
             );
             data.as_mut_ptr()
@@ -406,7 +406,7 @@ impl Pixbuf {
             if error.is_null() {
                 Ok(FromGlibContainer::from_glib_full_num(
                     buffer,
-                    buffer_size.assume_init() as usize,
+                    buffer_size.assume_init() as _,
                 ))
             } else {
                 Err(from_glib_full(error))