Merge pull request #1109 from sdroege/clippy-warnings

Clippy warnings

Author: sdroege

cairo/src/svg.rs

@@ -146,10 +146,11 @@ mod test {
         *surface.finish_output_stream().unwrap().downcast().unwrap()
     }
 
+    #[track_caller]
     fn assert_len_close_enough(len_a: usize, len_b: usize) {
         // It seems cairo randomizes some element IDs which might make one svg slightly
         // larger than the other. Here we make sure the difference is within ~10%.
-        let len_diff = (len_a as isize - len_b as isize).abs() as usize;
+        let len_diff = usize::abs_diff(len_a, len_b);
         assert!(len_diff < len_b / 10);
     }
 

glib-macros/src/utils.rs

@@ -248,7 +248,7 @@ mod tests {
             .required()
             .value_required();
         let _ = parse_nested_meta_items(&input.attrs, "boxed_type", &mut [&mut gtype_name]);
-        assert_eq!(gtype_name.get_found(), true);
+        assert!(gtype_name.get_found());
         assert_eq!(
             gtype_name.value.map(|x| x.value()),
             Some("Author".to_string())
@@ -271,6 +271,6 @@ mod tests {
         assert!(gtype_name.value.is_none());
 
         // The argument key must be found though
-        assert_eq!(gtype_name.get_found(), true);
+        assert!(gtype_name.get_found());
     }
 }

glib/src/translate.rs

@@ -958,7 +958,7 @@ macro_rules! impl_to_glib_container_from_slice_fundamental {
                 }
 
                 unsafe {
-                    let res = ffi::g_malloc(mem::size_of::<$name>() * t.len()) as *mut $name;
+                    let res = ffi::g_malloc(mem::size_of_val(t)) as *mut $name;
                     ptr::copy_nonoverlapping(t.as_ptr(), res, t.len());
                     res
                 }

pangocairo/Gir.toml

@@ -10,9 +10,7 @@ single_version_file = true
 deprecate_by_min_version = true
 trust_return_value_nullability = true
 
-generate = [
-    "PangoCairo.Font",
-]
+generate = []
 
 manual = [
     "cairo.Context",
@@ -101,15 +99,21 @@ status = "generate"
     name = "cr"
     const = true
 
+[[object]]
+name = "PangoCairo.Font"
+status = "generate"
+trait_name = "PangoCairoFontExt"
+
 [[object]]
 name = "PangoCairo.FontMap"
 status = "generate"
-manual_traits = ["FontMapExtManual"]
+trait_name = "PangoCairoFontMapExt"
+manual_traits = ["PangoCairoFontMapExtManual"]
     [[object.function]]
     # Needed because cairo types don't implement `.into_glib()`.
     name = "get_font_type"
     manual = true
-    doc_trait_name = "FontMapExtManual"
+    doc_trait_name = "PangoCairoFontMapExtManual"
     [[object.function]]
     # Needed because cairo types don't implement `.into_glib()`.
     name = "new_for_font_type"

pangocairo/src/auto/font.rs

@@ -18,7 +18,7 @@ impl Font {
     pub const NONE: Option<&'static Font> = None;
 }
 
-pub trait FontExt: IsA<Font> + 'static {
+pub trait PangoCairoFontExt: IsA<Font> + 'static {
     #[doc(alias = "pango_cairo_font_get_scaled_font")]
     #[doc(alias = "get_scaled_font")]
     fn scaled_font(&self) -> Option<cairo::ScaledFont> {
@@ -30,7 +30,7 @@ pub trait FontExt: IsA<Font> + 'static {
     }
 }
 
-impl<O: IsA<Font>> FontExt for O {}
+impl<O: IsA<Font>> PangoCairoFontExt for O {}
 
 impl fmt::Display for Font {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

pangocairo/src/auto/font_map.rs

@@ -25,7 +25,7 @@ impl FontMap {
     }
 }
 
-pub trait FontMapExt: IsA<FontMap> + 'static {
+pub trait PangoCairoFontMapExt: IsA<FontMap> + 'static {
     #[doc(alias = "pango_cairo_font_map_get_resolution")]
     #[doc(alias = "get_resolution")]
     fn resolution(&self) -> f64 {
@@ -40,7 +40,7 @@ pub trait FontMapExt: IsA<FontMap> + 'static {
     }
 }
 
-impl<O: IsA<FontMap>> FontMapExt for O {}
+impl<O: IsA<FontMap>> PangoCairoFontMapExt for O {}
 
 impl fmt::Display for FontMap {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {

pangocairo/src/auto/mod.rs

@@ -12,6 +12,6 @@ pub mod functions;
 
 #[doc(hidden)]
 pub mod traits {
-    pub use super::font::FontExt;
-    pub use super::font_map::FontMapExt;
+    pub use super::font::PangoCairoFontExt;
+    pub use super::font_map::PangoCairoFontMapExt;
 }

pangocairo/src/font_map.rs

@@ -4,15 +4,15 @@ use glib::{prelude::*, translate::*};
 
 use crate::FontMap;
 
-pub trait FontMapExtManual: IsA<FontMap> + 'static {
+pub trait PangoCairoFontMapExtManual: IsA<FontMap> + 'static {
     #[doc(alias = "pango_cairo_font_map_get_font_type")]
     #[doc(alias = "get_font_type")]
     fn font_type(&self) -> cairo::FontType {
         unsafe { ffi::pango_cairo_font_map_get_font_type(self.as_ref().to_glib_none().0).into() }
     }
 }
 
-impl<O: IsA<FontMap>> FontMapExtManual for O {}
+impl<O: IsA<FontMap>> PangoCairoFontMapExtManual for O {}
 
 impl FontMap {
     #[doc(alias = "pango_cairo_font_map_new_for_font_type")]

pangocairo/src/prelude.rs

@@ -5,4 +5,4 @@ pub use glib::prelude::*;
 #[doc(hidden)]
 pub use pango::prelude::*;
 
-pub use crate::{auto::traits::*, font_map::FontMapExtManual};
+pub use crate::{auto::traits::*, font_map::PangoCairoFontMapExtManual};