Don't seal manual traits that correspond to auto-generated types

bilelmoussaoui · bilelmoussaoui · commit d60d6de8b265 · 2024-10-18T19:08:55.000+02:00
As those have already the IsA&lt;T&gt; restriction which is an unsafe trait, implemented
by the glib::wrapper! macro.
diff --git a/gdk4-wayland/src/wayland_surface.rs b/gdk4-wayland/src/wayland_surface.rs
@@ -11,15 +11,10 @@ use wayland_client::{backend::ObjectId, protocol::wl_surface::WlSurface, Proxy};
 use crate::ffi;
 use crate::{prelude::*, WaylandSurface};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::WaylandSurface>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`WaylandSurface`](crate::WaylandSurface).
-pub trait WaylandSurfaceExtManual: sealed::Sealed + IsA<WaylandSurface> + 'static {
+pub trait WaylandSurfaceExtManual: IsA<WaylandSurface> + 'static {
     #[doc(alias = "gdk_wayland_surface_get_wl_surface")]
     #[doc(alias = "get_wl_surface")]
     #[cfg(feature = "wayland_crate")]
diff --git a/gdk4/src/content_provider.rs b/gdk4/src/content_provider.rs
@@ -4,15 +4,10 @@ use glib::translate::*;
 
 use crate::{ffi, prelude::*, ContentProvider};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::ContentProvider>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`ContentProvider`](crate::ContentProvider).
-pub trait ContentProviderExtManual: sealed::Sealed + IsA<ContentProvider> {
+pub trait ContentProviderExtManual: IsA<ContentProvider> {
     #[doc(alias = "gdk_content_provider_get_value")]
     fn value(&self, type_: glib::Type) -> Result<glib::Value, glib::Error> {
         unsafe {
diff --git a/gdk4/src/display.rs b/gdk4/src/display.rs
@@ -50,15 +50,10 @@ impl Backend {
     }
 }
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Display>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`Display`](crate::Display).
-pub trait DisplayExtManual: sealed::Sealed + IsA<Display> + 'static {
+pub trait DisplayExtManual: IsA<Display> + 'static {
     #[doc(alias = "gdk_display_translate_key")]
     fn translate_key(
         &self,
diff --git a/gdk4/src/drag_surface.rs b/gdk4/src/drag_surface.rs
@@ -9,15 +9,10 @@ use glib::{
 
 use crate::{ffi, prelude::*, DragSurface, DragSurfaceSize};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::DragSurface>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`DragSurface`](crate::DragSurface).
-pub trait DragSurfaceExtManual: sealed::Sealed + IsA<DragSurface> {
+pub trait DragSurfaceExtManual: IsA<DragSurface> {
     #[cfg(feature = "v4_12")]
     #[cfg_attr(docsrs, doc(cfg(feature = "v4_12")))]
     #[doc(alias = "compute-size")]
diff --git a/gdk4/src/draw_context.rs b/gdk4/src/draw_context.rs
@@ -4,15 +4,10 @@ use glib::translate::*;
 
 use crate::{prelude::*, DrawContext};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::DrawContext>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`DrawContext`](crate::DrawContext).
-pub trait DrawContextExtManual: sealed::Sealed + IsA<DrawContext> + 'static {
+pub trait DrawContextExtManual: IsA<DrawContext> + 'static {
     #[doc(alias = "gdk_draw_context_get_frame_region")]
     #[doc(alias = "get_frame_region")]
     fn frame_region(&self) -> Option<cairo::Region> {
diff --git a/gdk4/src/surface.rs b/gdk4/src/surface.rs
@@ -4,15 +4,10 @@ use glib::translate::*;
 
 use crate::{ffi, prelude::*, Surface};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Surface>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`Surface`](crate::Surface).
-pub trait SurfaceExtManual: sealed::Sealed + IsA<Surface> + 'static {
+pub trait SurfaceExtManual: IsA<Surface> + 'static {
     #[doc(alias = "gdk_surface_create_similar_surface")]
     fn create_similar_surface(
         &self,
diff --git a/gdk4/src/texture.rs b/gdk4/src/texture.rs
@@ -4,15 +4,10 @@ use glib::translate::*;
 
 use crate::{ffi, prelude::*, Texture};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Texture>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`Texture`](crate::Texture).
-pub trait TextureExtManual: sealed::Sealed + IsA<Texture> + 'static {
+pub trait TextureExtManual: IsA<Texture> + 'static {
     #[doc(alias = "gdk_texture_download")]
     fn download(&self, data: &mut [u8], stride: usize) {
         unsafe {
diff --git a/gdk4/src/toplevel.rs b/gdk4/src/toplevel.rs
@@ -9,15 +9,10 @@ use glib::{
 
 use crate::{ffi, prelude::*, Toplevel, ToplevelSize};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Toplevel>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`Toplevel`](crate::Toplevel).
-pub trait ToplevelExtManual: sealed::Sealed + IsA<Toplevel> {
+pub trait ToplevelExtManual: IsA<Toplevel> {
     fn connect_compute_size<F: Fn(&Toplevel, &mut ToplevelSize) + 'static>(
         &self,
         f: F,
diff --git a/gtk4/src/accessible.rs b/gtk4/src/accessible.rs
@@ -7,11 +7,6 @@ use crate::{
     AccessibleProperty, AccessibleRelation, AccessibleSort, AccessibleState, AccessibleTristate,
     Orientation,
 };
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Accessible>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`Accessible`](crate::Accessible).
@@ -30,7 +25,7 @@ mod sealed {
 ///     gtk::AccessibleInvalidState::Grammar,
 /// )]);
 /// ```
-pub trait AccessibleExtManual: sealed::Sealed + IsA<Accessible> {
+pub trait AccessibleExtManual: IsA<Accessible> {
     #[doc(alias = "gtk_accessible_update_property")]
     #[doc(alias = "gtk_accessible_update_property_value")]
     fn update_property(&self, properties: &[Property]) {
diff --git a/gtk4/src/actionable.rs b/gtk4/src/actionable.rs
@@ -4,15 +4,10 @@ use glib::{translate::*, Variant};
 
 use crate::{prelude::*, Actionable};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Actionable>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`Actionable`](crate::Actionable).
-pub trait ActionableExtManual: sealed::Sealed + IsA<Actionable> + 'static {
+pub trait ActionableExtManual: IsA<Actionable> + 'static {
     #[doc(alias = "gtk_actionable_set_action_target")]
     #[doc(alias = "gtk_actionable_set_action_target_value")]
     fn set_action_target(&self, target: Option<impl Into<Variant>>) {
diff --git a/gtk4/src/cell_area.rs b/gtk4/src/cell_area.rs
@@ -4,17 +4,12 @@ use glib::{translate::*, value::FromValue, Value};
 
 use crate::{ffi, prelude::*, CellArea, CellRenderer};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::CellArea>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`CellArea`](crate::CellArea).
 #[cfg_attr(feature = "v4_10", deprecated = "Since 4.10")]
 #[allow(deprecated)]
-pub trait CellAreaExtManual: sealed::Sealed + IsA<CellArea> {
+pub trait CellAreaExtManual: IsA<CellArea> {
     #[doc(alias = "gtk_cell_area_add_with_properties")]
     fn add_with_properties(
         &self,
diff --git a/gtk4/src/cell_layout.rs b/gtk4/src/cell_layout.rs
@@ -4,16 +4,12 @@ use glib::translate::*;
 
 use crate::{prelude::*, CellLayout, CellRenderer};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::CellLayout>> Sealed for T {}
-}
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`CellLayout`](crate::CellLayout).
 #[cfg_attr(feature = "v4_10", deprecated = "Since 4.10")]
 #[allow(deprecated)]
-pub trait CellLayoutExtManual: sealed::Sealed + IsA<CellLayout> + 'static {
+pub trait CellLayoutExtManual: IsA<CellLayout> + 'static {
     #[doc(alias = "gtk_cell_layout_set_attributes")]
     fn set_attributes(&self, cell: &impl IsA<CellRenderer>, attributes: &[(&str, i32)]) {
         self.as_ref().clear_attributes(cell);
diff --git a/gtk4/src/color_chooser.rs b/gtk4/src/color_chooser.rs
@@ -6,17 +6,12 @@ use libc::c_int;
 
 use crate::{ffi, prelude::*, ColorChooser, Orientation};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::ColorChooser>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`ColorChooser`](crate::ColorChooser).
 #[cfg_attr(feature = "v4_10", deprecated = "Since 4.10")]
 #[allow(deprecated)]
-pub trait ColorChooserExtManual: sealed::Sealed + IsA<ColorChooser> + 'static {
+pub trait ColorChooserExtManual: IsA<ColorChooser> + 'static {
     #[doc(alias = "gtk_color_chooser_add_palette")]
     fn add_palette(&self, orientation: Orientation, colors_per_line: i32, colors: &[RGBA]) {
         unsafe {
diff --git a/gtk4/src/combo_box.rs b/gtk4/src/combo_box.rs
@@ -4,17 +4,12 @@ use glib::translate::*;
 
 use crate::{ffi, prelude::*, ComboBox};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::ComboBox>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`ComboBox`](crate::ComboBox).
 #[cfg_attr(feature = "v4_10", deprecated = "Since 4.10")]
 #[allow(deprecated)]
-pub trait ComboBoxExtManual: sealed::Sealed + IsA<ComboBox> + 'static {
+pub trait ComboBoxExtManual: IsA<ComboBox> + 'static {
     #[doc(alias = "gtk_combo_box_set_row_separator_func")]
     #[doc(alias = "set_row_separator_func")]
     fn unset_row_separator_func(&self) {
diff --git a/gtk4/src/dialog.rs b/gtk4/src/dialog.rs
@@ -41,16 +41,11 @@ impl Dialog {
     }
 }
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Dialog>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of [`Dialog`](crate::Dialog).
 #[cfg_attr(feature = "v4_10", deprecated = "Since 4.10")]
 #[allow(deprecated)]
-pub trait DialogExtManual: sealed::Sealed + IsA<Dialog> + 'static {
+pub trait DialogExtManual: IsA<Dialog> + 'static {
     #[doc(alias = "gtk_dialog_add_buttons")]
     fn add_buttons(&self, buttons: &[(&str, ResponseType)]) {
         for &(text, id) in buttons {
diff --git a/gtk4/src/drawing_area.rs b/gtk4/src/drawing_area.rs
@@ -6,15 +6,10 @@ use glib::translate::*;
 
 use crate::{ffi, prelude::*, DrawingArea};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::DrawingArea>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`DrawingArea`](crate::DrawingArea).
-pub trait DrawingAreaExtManual: sealed::Sealed + IsA<DrawingArea> + 'static {
+pub trait DrawingAreaExtManual: IsA<DrawingArea> + 'static {
     #[doc(alias = "gtk_drawing_area_set_draw_func")]
     #[doc(alias = "set_draw_func")]
     fn unset_draw_func(&self) {
diff --git a/gtk4/src/editable.rs b/gtk4/src/editable.rs
@@ -9,15 +9,11 @@ use glib::{
 use libc::{c_char, c_int, c_uchar};
 
 use crate::{prelude::*, Editable};
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Editable>> Sealed for T {}
-}
 
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`Editable`](crate::Editable).
-pub trait EditableExtManual: sealed::Sealed + IsA<Editable> + 'static {
+pub trait EditableExtManual: IsA<Editable> + 'static {
     fn connect_insert_text<F>(&self, f: F) -> SignalHandlerId
     where
         F: Fn(&Self, &str, &mut i32) + 'static,
diff --git a/gtk4/src/entry.rs b/gtk4/src/entry.rs
@@ -4,14 +4,9 @@ use glib::translate::*;
 
 use crate::{prelude::*, Entry};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::Entry>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of [`Entry`](crate::Entry).
-pub trait EntryExtManual: sealed::Sealed + IsA<Entry> + 'static {
+pub trait EntryExtManual: IsA<Entry> + 'static {
     #[doc(alias = "gtk_entry_get_invisible_char")]
     #[doc(alias = "get_invisible_char")]
     fn invisible_char(&self) -> Option<char> {
diff --git a/gtk4/src/entry_buffer.rs b/gtk4/src/entry_buffer.rs
@@ -30,15 +30,11 @@ macro_rules! to_u16 {
         }
     )
 }
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::EntryBuffer>> Sealed for T {}
-}
 
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`EntryBuffer`](crate::EntryBuffer).
-pub trait EntryBufferExtManual: sealed::Sealed + IsA<EntryBuffer> + 'static {
+pub trait EntryBufferExtManual: IsA<EntryBuffer> + 'static {
     #[doc(alias = "gtk_entry_buffer_delete_text")]
     fn delete_text(&self, position: u16, n_chars: Option<u16>) -> u16 {
         unsafe {
diff --git a/gtk4/src/file_chooser.rs b/gtk4/src/file_chooser.rs
@@ -3,17 +3,12 @@
 use crate::{ffi, prelude::*, FileChooser};
 use glib::translate::*;
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::FileChooser>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`FileChooser`](crate::FileChooser).
 #[cfg_attr(feature = "v4_10", deprecated = "Since 4.10")]
 #[allow(deprecated)]
-pub trait FileChooserExtManual: sealed::Sealed + IsA<FileChooser> + 'static {
+pub trait FileChooserExtManual: IsA<FileChooser> + 'static {
     #[doc(alias = "gtk_file_chooser_add_choice")]
     fn add_choice(&self, id: impl IntoGStr, label: impl IntoGStr, options: &[(&str, &str)]) {
         if options.is_empty() {
diff --git a/gtk4/src/font_chooser.rs b/gtk4/src/font_chooser.rs
@@ -4,17 +4,12 @@ use glib::translate::*;
 
 use crate::{prelude::*, FontChooser};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::FontChooser>> Sealed for T {}
-}
-
 // rustdoc-stripper-ignore-next
 /// Trait containing manually implemented methods of
 /// [`FontChooser`](crate::FontChooser).
 #[cfg_attr(feature = "v4_10", deprecated = "Since 4.10")]
 #[allow(deprecated)]
-pub trait FontChooserExtManual: sealed::Sealed + IsA<FontChooser> + 'static {
+pub trait FontChooserExtManual: IsA<FontChooser> + 'static {
     #[doc(alias = "gtk_font_chooser_set_filter_func")]
     #[doc(alias = "set_filter_func")]
     fn unset_filter_func(&self) {
diff --git a/gtk4/src/media_stream.rs b/gtk4/src/media_stream.rs
@@ -4,12 +4,7 @@ use glib::translate::*;
 
 use crate::{prelude::*, MediaStream};
 
-mod sealed {
-    pub trait Sealed {}
-    impl<T: super::IsA<super::MediaStream>> Sealed for T {}
-}
-
-pub trait MediaStreamExtManual: sealed::Sealed + IsA<MediaStream> + 'static {
+pub trait MediaStreamExtManual: IsA<MediaStream> + 'static {
     #[doc(alias = "gtk_media_stream_gerror")]
     #[doc(alias = "gtk_media_stream_error")]
     #[doc(alias = "gerror")]
diff --git a/gtk4/src/native_dialog.rs b/gtk4/src/native_dialog.rs
diff --git a/gtk4/src/scale.rs b/gtk4/src/scale.rs
diff --git a/gtk4/src/shortcut_trigger.rs b/gtk4/src/shortcut_trigger.rs
diff --git a/gtk4/src/snapshot.rs b/gtk4/src/snapshot.rs
diff --git a/gtk4/src/text_buffer.rs b/gtk4/src/text_buffer.rs
diff --git a/gtk4/src/tree_model.rs b/gtk4/src/tree_model.rs
diff --git a/gtk4/src/tree_model_filter.rs b/gtk4/src/tree_model_filter.rs
diff --git a/gtk4/src/tree_sortable.rs b/gtk4/src/tree_sortable.rs
diff --git a/gtk4/src/tree_view.rs b/gtk4/src/tree_view.rs
diff --git a/gtk4/src/widget.rs b/gtk4/src/widget.rs
