gtk::DragIcon::for_drag returns Widget, not DragIcon

[felinira]

gtk::DragIcon::for_drag returns a gtk::Widget. Usually we return the concrete type in such methods.

[bilelmoussaoui]

Should be fixed upstream https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtkdragicon.c#L413

[felinira]

All constructor functions also return gtk::Widget and we override the return value. Like gtk::Image::from_icon_name. This is also (mostly) a constructor (apart from the fact that dragicons automatically store themselves in qdata of the drag)

[bilelmoussaoui]

from_icon_name

I don't see where we override those...

[bilelmoussaoui]

I see why, gtk_drag_icon_get_for_drag is not marked as a constructor.

[bilelmoussaoui]

Sent a fix upstream