Skip to content

Conversation

@daxhuiberts
Copy link
Contributor

This will make ashpd only a dependency on linux.

An alternative would be something like cfg(all(unix, not(target_os = "macos"))) to still include it for all other unix family.

@bilelmoussaoui
Copy link
Member

The code using it should also be behind a similar guard

@daxhuiberts
Copy link
Contributor Author

The code using it should also be behind a similar guard

I looked into disabling the main_event_loop_7 bin, but there currently is no simple way to achieve that (see rust-lang/cargo#9208)
Not sure what the appropriate approach would be in this case.

@daxhuiberts
Copy link
Contributor Author

I made a change to main_event_loop_7 with a possible solution, but this approach is probably not desirable.

@daxhuiberts daxhuiberts force-pushed the include-ashpd-only-on-linux branch from 65c20dd to 1c6931b Compare October 17, 2024 19:47
@bilelmoussaoui
Copy link
Member

Also, please fix the formatting, otherwise the suggested solution is the best we can do so it is fine.

@daxhuiberts daxhuiberts force-pushed the include-ashpd-only-on-linux branch from 1c6931b to 83420d7 Compare October 17, 2024 19:56
@daxhuiberts daxhuiberts force-pushed the include-ashpd-only-on-linux branch from 83420d7 to d5a0833 Compare October 17, 2024 19:57
@daxhuiberts
Copy link
Contributor Author

Thanks for the feedback.
Fixed the newline and formatting.

@bilelmoussaoui bilelmoussaoui merged commit b7f4575 into gtk-rs:master Oct 17, 2024
2 of 3 checks passed
@bilelmoussaoui
Copy link
Member

Thanks!

@daxhuiberts daxhuiberts deleted the include-ashpd-only-on-linux branch October 18, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants