gdk4-macos: manually implement native_window method #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacho
force-pushed
the
wip/nacho/nswindow
branch
from
be2391a to
bf76556
Compare
nacho
force-pushed
the
wip/nacho/nswindow
branch
2 times, most recently
from
8ab2721 to
7a38527
Compare
nacho
force-pushed
the
wip/nacho/nswindow
branch
4 times, most recently
from
27885fa to
db6353d
Compare
nacho
force-pushed
the
wip/nacho/nswindow
branch
3 times, most recently
from
59d6bde to
37c95b3
Compare
bilelmoussaoui
approved these changes
Dec 9, 2024
|
The changes looks good to me, but the docs CI as being run on a linux machine seems to fail at linking cocoa, which is weird as it is an optional feature... |
I wonder if it has something to do with the fact that the feature name is cocoa and the dependency is also cocoa... |
|
The docs build uses |
|
I wonder how this works for windows then... checking |
nacho
force-pushed
the
wip/nacho/nswindow
branch
from
6e08ebf to
131dd95
Compare
|
Can you rebase this one? |
For now we need to depend on the cocoa crate in order to implement this method since it is the only decent crate implementing the cocoa api.
nacho
force-pushed
the
wip/nacho/nswindow
branch
from
131dd95 to
0dde555
Compare
sdroege
reviewed
Dec 18, 2024
sdroege
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we need to depend on the cocoa crate in order to implement this method since it is the only decent crate implementing the cocoa api.