Don't skip Option for nullable collections
#2064
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengalin
force-pushed
the
nullable-arrays
branch
2 times, most recently
from
e35fe9a to
0bfb145
Compare
| @@ -16,7 +16,7 @@ glib::wrapper! { | |||
|
|
|||
| impl StringList { | |||
| #[doc(alias = "gtk_string_list_new")] | |||
| pub fn new(strings: &[&str]) -> StringList { | |||
| pub fn new(strings: Option<&[&str]>) -> StringList { | |||
There was a problem hiding this comment.
those two don't make sense to have as nullable
There was a problem hiding this comment.
ok, I'll update this later. Need to move to something else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consequence of gtk-rs/gir#1622