Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This PR contains auto-generated changes after a merge in the external gir-files repository.

@github-actions github-actions bot requested a review from bilelmoussaoui as a code owner July 27, 2025 11:17
@github-actions github-actions bot force-pushed the auto-pr-branch branch 2 times, most recently from 4990aba to 044d205 Compare August 5, 2025 08:04
@sdroege
Copy link
Member

sdroege commented Aug 5, 2025

FWIW, This would unbreak the CI

@github-actions github-actions bot force-pushed the auto-pr-branch branch 2 times, most recently from 5cc0821 to 98e4a87 Compare August 19, 2025 08:05
@sdroege sdroege force-pushed the auto-pr-branch branch 2 times, most recently from 38be2ac to bf08107 Compare August 25, 2025 08:20
@sdroege
Copy link
Member

sdroege commented Aug 25, 2025

Windows build is broken in strange ways

Successfully installed meson-1.9.0 ninja-1.13.0 packaging-25.0 setuptools-80.9.0
[...]
gi-docgen| Program python3 (jinja2, markdown, markupsafe, packaging, pygments, typogrify) found: NO modules: packaging

@sdroege
Copy link
Member

sdroege commented Aug 25, 2025

@bilelmoussaoui This should be finally ready except for the Windows problem (which also exists before this PR). Any ideas how to solve that one?

@bilelmoussaoui
Copy link
Member

it should be easily fixable by adding -Dgdk-pixbuf:documentation=false to https://github.com/gtk-rs/gtk4-rs/blob/main/.github/workflows/windows-msvc.yml#L78 or so

@sdroege
Copy link
Member

sdroege commented Aug 25, 2025

Let's try that. Not a solution of course but good enough here

Given that sometimes gtk will randomly fail to build
@bilelmoussaoui bilelmoussaoui merged commit 35bb4b9 into main Aug 25, 2025
40 of 41 checks passed
@bilelmoussaoui bilelmoussaoui deleted the auto-pr-branch branch August 25, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants