Skip to content

Commit 1b9bab3

Browse files
committed
Typo "expended" changed to "expanded"
Fixes #29 Signed-off-by: Daniel Kastl <[email protected]>
1 parent 09f35b5 commit 1b9bab3

File tree

8 files changed

+13
-13
lines changed

8 files changed

+13
-13
lines changed

app/views/issues/_form_custom_fields.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<% end %>
55
<% fieldset_default_state = User.current.pref.fieldset_default_state %>
66
<% if fieldset_default_state.blank? %>
7-
<% fieldset_default_state = Setting.plugin_redmine_custom_fields_groups['fieldset_default_state'] || 'all_expended' %>
7+
<% fieldset_default_state = Setting.plugin_redmine_custom_fields_groups['fieldset_default_state'] || 'all_expanded' %>
88
<% end %>
99
<% all_collapsed = (fieldset_default_state == 'all_collapsed') %>
1010
<% grouped_custom_field_values(@issue.editable_custom_field_values).each do |title, values| %>
@@ -35,7 +35,7 @@
3535
<% end %>
3636
<% else %>
3737
<% fieldset_class = 'collapsible custom-fields-groups' + (all_collapsed ? ' collapsed' : '') %>
38-
<% legend_class = 'icon icon-' + (all_collapsed ? 'collapsed' : ((Redmine::VERSION.to_s >= '5.0.0') ? 'expanded' : 'expended')) %>
38+
<% legend_class = 'icon icon-' + (all_collapsed ? 'collapsed' : ((Redmine::VERSION.to_s >= '5.0.0') ? 'expanded' : 'expanded')) %>
3939
<% div_style = all_collapsed ? 'display: none' : '' %>
4040
<fieldset class="<%= fieldset_class %>">
4141
<%= content_tag('legend', title, :onclick => "toggleFieldset(this);", :class => legend_class) %>

config/locales/en.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ en:
99
label_group_tag_h4: H4
1010
label_group_tag_fieldset: Fieldset
1111
label_fieldset_default_state: Fieldset Default State
12-
label_fieldset_state_all_expended: All expended
12+
label_fieldset_state_all_expanded: All expanded
1313
label_fieldset_state_all_collapsed: All collapsed
1414
error_can_not_delete_custom_fields_group: Unable to delete custom fields group

config/locales/ja.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ ja:
99
label_group_tag_h4: H4
1010
label_group_tag_fieldset: フィールドセット
1111
label_fieldset_default_state: フィールドセットのデフォルト状態
12-
label_fieldset_state_all_expended: 全て展開
12+
label_fieldset_state_all_expanded: 全て展開
1313
label_fieldset_state_all_collapsed: 全て折りたたみ
1414
error_can_not_delete_custom_fields_group: カスタムフィールドグループを削除できません。

init.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
settings partial: 'settings/redmine_custom_fields_groups',
1515
default: {
1616
'custom_fields_group_tag' => 'h4',
17-
'fieldset_default_state' => 'all_expended'
17+
'fieldset_default_state' => 'all_expanded'
1818
}
1919

2020
menu :admin_menu,

lib/redmine_custom_fields_groups/options.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def self.group_tags
1010
end
1111
def self.fieldset_states
1212
[
13-
[l(:label_fieldset_state_all_expended), "all_expended"],
13+
[l(:label_fieldset_state_all_expanded), "all_expanded"],
1414
[l(:label_fieldset_state_all_collapsed), "all_collapsed"],
1515
]
1616
end

lib/redmine_custom_fields_groups/patches/issues_helper_patch.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def render_custom_fields_rows_by_groups(issue)
3333
end
3434
fieldset_default_state = User.current.pref.fieldset_default_state
3535
if fieldset_default_state.blank?
36-
fieldset_default_state = Setting.plugin_redmine_custom_fields_groups['fieldset_default_state'] || 'all_expended'
36+
fieldset_default_state = Setting.plugin_redmine_custom_fields_groups['fieldset_default_state'] || 'all_expanded'
3737
end
3838

3939
s = ''.html_safe
@@ -46,7 +46,7 @@ def render_custom_fields_rows_by_groups(issue)
4646
else
4747
s << content_tag('fieldset', :class => 'collapsible custom-fields-groups') do
4848
concat content_tag('legend', title, :onclick => 'toggleFieldset(this);',
49-
:class => 'icon icon-' + ((Redmine::VERSION.to_s >= '5.0.0') ? 'expanded' : 'expended'))
49+
:class => 'icon icon-' + ((Redmine::VERSION.to_s >= '5.0.0') ? 'expanded' : 'expanded'))
5050
concat render_half_width_custom_fields_rows_by_grouped_values(issue, values)
5151
concat render_full_width_custom_fields_rows_by_grouped_values(issue, values)
5252
end

test/integration/layout_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,10 @@ class LayoutTest < Redmine::IntegrationTest
130130
end
131131
end
132132

133-
test 'should show custom fields groups with fieldset tag all expended in issue from plugin setting' do
133+
test 'should show custom fields groups with fieldset tag all expanded in issue from plugin setting' do
134134
Setting.plugin_redmine_custom_fields_groups = {
135135
'custom_fields_group_tag' => 'fieldset',
136-
'fieldset_default_state' => 'all_expended'
136+
'fieldset_default_state' => 'all_expanded'
137137
}
138138

139139
log_user('dlopper', 'foo')
@@ -196,7 +196,7 @@ class LayoutTest < Redmine::IntegrationTest
196196
}
197197

198198
@user.pref.others[:custom_fields_group_tag] = 'fieldset'
199-
@user.pref.others[:fieldset_default_state] = 'all_expended'
199+
@user.pref.others[:fieldset_default_state] = 'all_expanded'
200200
@user.pref.save!
201201

202202
log_user('dlopper', 'foo')

test/system/fieldset_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ class FieldsetTest < ApplicationSystemTestCase
1313
Setting.clear_cache
1414
end
1515

16-
test 'click group title should collapse/expand fieldset with default state all_expended' do
16+
test 'click group title should collapse/expand fieldset with default state all_expanded' do
1717
Setting.plugin_redmine_custom_fields_groups = {
1818
'custom_fields_group_tag' => 'fieldset',
19-
'fieldset_default_state' => 'all_expended'
19+
'fieldset_default_state' => 'all_expanded'
2020
}
2121

2222
log_user('dlopper', 'foo')

0 commit comments

Comments
 (0)