adds push user preference and implements sending #1

Author: jkraemer

app/controllers/expo_push_tokens_controller.rb

@@ -1,6 +1,6 @@
 class ExpoPushTokensController < ApplicationController
   before_action :require_login
-  accept_api_auth :create
+  accept_api_auth :create, :destroy_all
 
   def create
     @token = ExpoPushToken.new user: User.current, token: params[:token]
@@ -14,4 +14,19 @@ def create
       end
     end
   end
+
+  def destroy_all
+    user_id = params[:user_id].to_i if User.current.admin? and params[:user_id].present?
+    user_id ||= User.current.id
+    ExpoPushToken.where(user_id: user_id).delete_all
+    respond_to do |format|
+      format.api { head :ok }
+      format.html {
+        flash[:notice] = l(:notice_account_updated)
+        redirect_to (User.current.admin? and user_id != User.current.id) ?
+          edit_user_path(id: user_id) :
+          my_account_path
+      }
+    end
+  end
 end

app/views/hooks/redmine_expo_push/_my_account_preferences.html.erb

@@ -0,0 +1,11 @@
+<p>
+  <%= labelled_fields_for :pref, @user.pref do |pref_fields| %>
+    <%= pref_fields.select :push_notifications, ['disabled', 'enabled', 'enabled_no_email'].map{|k| [t(".push_notifications.#{k}"), k]}, include_blank: false %>
+  <% end %>
+  <em class="info">
+    <% count = @user.expo_push_tokens.count %>
+    <%= t '.x_devices_registered', count: count %>
+    <%= link_to t(".delete#{'_all' if count > 1}"), expo_push_tokens_path(user_id: @user.id), confirm: t("text_are_you_sure"), method: :delete if count > 0 %>
+  </em>
+</p>
+

config/locales/en.yml

@@ -0,0 +1,14 @@
+en:
+  hooks:
+    redmine_expo_push:
+      my_account_preferences:
+        delete: Remove
+        delete_all: Remove all
+        push_notifications:
+          enabled: Enabled
+          disabled: Disabled
+          enabled_no_email: Enabled, no emails
+        x_devices_registered:
+          zero: Currently no devices are registered.
+          one: Currently one device is registered.
+          other: "Currently %{count} devices are registered."

config/routes.rb

@@ -1 +1,2 @@
-resources :expo_push_tokens, only: %i(create)
+resources :expo_push_tokens, only: %i(create) 
+delete "expo_push_tokens", to: "expo_push_tokens#destroy_all"

init.rb

@@ -1,5 +1,8 @@
 require 'redmine'
 
+require 'redmine_expo_push'
+require 'redmine_expo_push/hooks'
+
 Rails.configuration.to_prepare do
   RedmineExpoPush.setup
 end

lib/redmine_expo_push.rb

@@ -1,6 +1,7 @@
 module RedmineExpoPush
   def self.setup
-    # RedmineExpoPush::Patches::MailerPatch.apply
+    RedmineExpoPush::Patches::MailerPatch.apply
     RedmineExpoPush::Patches::UserPatch.apply
+    RedmineExpoPush::Patches::UserPreferencePatch.apply
   end
 end

lib/redmine_expo_push/hooks.rb

@@ -0,0 +1,7 @@
+module RedmineExpoPush
+  class Hooks < Redmine::Hook::ViewListener
+
+    # TODO it would be nice to have a hook in users/mail_notifications instead.
+    render_on :view_my_account_preferences, partial: "hooks/redmine_expo_push/my_account_preferences"
+  end
+end

lib/redmine_expo_push/notification.rb

@@ -1,12 +1,18 @@
 module RedmineExpoPush
   class Notification
+    attr_reader :title, :body, :data
+
     def initialize(title: nil, body: nil, data: {})
       @title = title
       @body = body
       @data = data
       @recipients = []
     end
 
+    def self.for(email)
+      new title: email.subject, body: email.text_part&.body&.decoded
+    end
+
     def add_recipient(user)
       @recipients << user
     end
@@ -18,7 +24,7 @@ def deliver
       messages = @recipients.map do |user|
         ExpoPushToken.where(user: user).map do |token|
           {
-            to: token,
+            to: token.token,
             title: @title,
             body: @body,
             data: @data
@@ -27,7 +33,11 @@ def deliver
       end
       messages.flatten!
 
-      Exponent::Push::Client.new(gzip: true).publish messages
+      begin
+        Exponent::Push::Client.new(gzip: true).publish messages
+      rescue Exception
+        Rails.logger.error "error sending push notifications:\n#{$!}\n" + $!.backtrace.join("\n")
+      end
     end
   end
 end

lib/redmine_expo_push/patches/mailer_patch.rb

@@ -1,7 +1,5 @@
 module RedmineExpoPush
   module Patches
-    # this is a draft, just in case we want to add general push notification
-    # support for all redmine notifications
     module MailerPatch
 
       def self.apply
@@ -22,13 +20,10 @@ def deliver_mail(mail, &block)
               skip_receivers = []
               receivers.each do |addr|
                 user = User.having_mail(addr).first
-                if user.present?
-                  cfg = RedmineExpoPush::UserConfig.new(user)
-                  if cfg.send_push_notifications?
-                    notification ||= Notification.new(mail)
-                    notification.add_recipient user
-                    skip_receivers << addr if cfg.skip_emails?
-                  end
+                if user.present? and user.send_push_notifications?
+                  notification ||= RedmineExpoPush::Notification.for(mail)
+                  notification.add_recipient user
+                  skip_receivers << addr if user.push_skip_emails?
                 end
               end
               mail.send "#{field}=", (receivers - skip_receivers)

lib/redmine_expo_push/patches/user_patch.rb

@@ -1,8 +1,27 @@
+# frozen_string_literal: true
+
 module RedmineExpoPush
   module Patches
     module UserPatch
       def self.apply
-        User.prepend self unless User < self
+        unless User < self
+          User.prepend self
+          User.class_eval do
+            has_many :expo_push_tokens
+          end
+        end
+      end
+
+      def push_device_registered?
+        expo_push_tokens.any?
+      end
+
+      def send_push_notifications?
+        pref.push_notifications != "disabled"
+      end
+
+      def push_skip_emails?
+        pref.push_notifications == "enabled_no_email"
       end
 
       def remove_references_before_destroy