Refactor settings views to remove unnecessary divs and improve layout with horizontal rules

Author: dkastl

app/views/settings/gtt/_general.html.erb

@@ -1,4 +1,3 @@
-<div class="box tabular settings">
 <h3><%= l(:select_default_map_settings) %></h3>
 
 <p>
@@ -41,9 +40,8 @@
       :size => 10) %>
 </p>
 
-</div>
+<hr>
 
-<div class="box tabular settings">
 <h3><%= l(:select_edit_geometry_settings) %></h3>
 
 <p>
@@ -62,9 +60,9 @@
   <%= content_tag(:label, l(:label_enable_geojson_upload_on_issue_map)) %>
   <%= check_box_tag 'settings[enable_geojson_upload_on_issue_map]', true, @settings[:enable_geojson_upload_on_issue_map] %>
 </p>
-</div>
 
-<div class="box tabular settings">
+<hr>
+
 <h3><%= l(:select_other_gtt_settings) %></h3>
 
 <p>
@@ -81,4 +79,3 @@
   <%= content_tag(:label, l(:label_hide_map_for_invalid_geom)) %>
   <%= check_box_tag 'settings[hide_map_for_invalid_geom]', 1, Setting.plugin_redmine_gtt['hide_map_for_invalid_geom'] %>
 </p>
-</div>

app/views/settings/gtt/_geocoder.html.erb

@@ -1,4 +1,3 @@
-<div class="box tabular settings">
 <h3><%= l(:select_default_geocoder_settings) %></h3>
 
 <p>
@@ -27,7 +26,6 @@
       :rows => 10,
       :cols => 100) %>
 </p>
-</div>
 
 <script>
   document.getElementById('geocoder_load_example').addEventListener('click', (event) => {

app/views/settings/gtt/_settings.html.erb

@@ -32,5 +32,5 @@
   });
 
   // Apply settings
-  window.gtt_setting()
+  window.gtt_setting();
 <% end %>

app/views/settings/gtt/_styling.html.erb

@@ -1,31 +1,31 @@
-<div class="box tabular settings">
 <h3><%= l(:select_default_tracker_icon) %></h3>
 
 <% Tracker.sorted.each do |t| %>
-  <p>
-    <%= content_tag :label, t.name %>
-    <%= select_tag "settings[tracker_#{t.id}]", "<option>#{@settings["tracker_#{t.id}"]}</option>".html_safe %>
-    <i id="icon_settings_tracker_<%= t.id %>"></i>
-  </p>
+<p>
+  <%= content_tag :label, t.name %>
+  <%= select_tag "settings[tracker_#{t.id}]", "<option>#{@settings["tracker_#{t.id}"]}</option>".html_safe %>
+  <i id="icon_settings_tracker_<%= t.id %>"></i>
+</p>
 <% end %>
-</div>
 
-<div class="box tabular settings">
+<hr>
+
 <h3><%= l(:select_default_status_color) %></h3>
 
 <% IssueStatus.sorted.each do |t| %>
-  <p>
-    <%= content_tag :label, t.name %>
-    <%= color_field_tag "settings[status_#{t.id}]", @settings["status_#{t.id}"] %>
-  </p>
+<p>
+  <%= content_tag :label, t.name %>
+  <%= color_field_tag "settings[status_#{t.id}]", @settings["status_#{t.id}"] %>
+</p>
 <% end %>
-</div>
 
-<div class="box tabular settings">
+<hr>
+
+<h3><%= l(:select_other_style_settings) %></h3>
+
 <p>
   <%= content_tag(:label, l(:gtt_settings_vector_minzoom_level)) %>
   <%= text_field_tag('settings[vector_minzoom_level]',
       @settings['vector_minzoom_level'],
       :size => 10 ) %>
 </p>
-</div>

config/locales/en.yml

@@ -69,6 +69,8 @@ en:
   select_edit_geometry_settings: "Set edit geometry settings:"
   select_default_geocoder_settings: "Set Geocoder settings:"
 
+  select_other_style_settings: "Other style settings"
+
   project_module_gtt: "GTT"
   permission_manage_gtt_settings: "Manage GTT settings"
   permission_view_gtt_settings: "View GTT settings"