don't do the class_eval blocks more than necessary #50

Author: jkraemer

lib/redmine_gtt/patches/issue_patch.rb

@@ -4,10 +4,12 @@ module Patches
     module IssuePatch
 
       def self.apply
-        Issue.prepend self unless Issue < self
-        Issue.class_eval do
-          safe_attributes "geom",
-            if: ->(issue, user){ user.allowed_to?(:edit_issues, issue.project)}
+        unless Issue < self
+          Issue.prepend self
+          Issue.class_eval do
+            safe_attributes "geom",
+              if: ->(issue, user){ user.allowed_to?(:edit_issues, issue.project)}
+          end
         end
       end
 

lib/redmine_gtt/patches/project_patch.rb

@@ -3,10 +3,12 @@ module Patches
 
     module ProjectPatch
       def self.apply
-        Project.prepend self unless Project < self
-        Project.class_eval do
-          safe_attributes "geom"
-          has_and_belongs_to_many :gtt_tile_sources
+        unless Project < self
+          Project.prepend self
+          Project.class_eval do
+            safe_attributes "geom"
+            has_and_belongs_to_many :gtt_tile_sources
+          end
         end
       end
 

lib/redmine_gtt/patches/user_patch.rb

@@ -3,9 +3,11 @@ module Patches
 
     module UserPatch
       def self.apply
-        User.prepend self unless User < self
-        User.class_eval do
-          safe_attributes "geom"
+        unless User < self
+          User.prepend self 
+          User.class_eval do
+            safe_attributes "geom"
+          end
         end
       end