Handles attachments

Signed-off-by: Daniel Kastl <[email protected]>

Author: dkastl

app/controllers/subscription_issues_controller.rb

@@ -1,100 +1,130 @@
+require 'net/http'
+require 'rack'
+
 class SubscriptionIssuesController < ApplicationController
 
   before_action :find_template_and_authorize
   skip_before_action :verify_authenticity_token, only: [:create]
   accept_api_auth :create
 
   def create
-    # Check if there's an existing issue with the same fiware_entity and subscription_template_id
-    # that was created within the threshold_create time frame
-    existing_issue = Issue.where(fiware_entity: params["entity"], subscription_template_id: @subscription_template.id)
-                      .where("created_on >= ?", Time.now - @subscription_template.threshold_create.seconds)
-                      .order(created_on: :desc)
-                      .first
+    @issue = find_or_initialize_issue
 
-    if existing_issue
-      # Create a new journal note for the existing issue
-      note = existing_issue.init_journal(User.current, params["notes"])
-
-      # If the redmine_gtt plugin is installed and enabled, and geometry data is provided,
-      # try to convert it to an RGeo geometry object and update the issue's geometry
-      if Redmine::Plugin.installed?(:redmine_gtt) && @subscription_template.project.module_enabled?('gtt') && params[:geometry]
-        begin
-          new_geom = RedmineGtt::Conversions.to_geom(params[:geometry].to_json)
-          if new_geom != existing_issue.geom
-            old_geom = existing_issue.geom
-            existing_issue.geom = new_geom
-            # Create a new JournalDetail record to track the change to the geom attribute
-            note.details.build(property: 'attr', prop_key: 'geom', old_value: old_geom, value: new_geom)
-          end
-        rescue => e
-          logger.warn "Failed to convert geometry data: #{e.message}"
-        end
-      end
+    if params[:attachments]
+      handle_attachments
+    end
 
-      # Save the existing issue and respond with the appropriate JSON response
-      if existing_issue.save
-        render json: existing_issue.as_json(include: [:status, :tracker, :author, :assigned_to, :journals]), status: :ok
-      else
-        render json: { errors: existing_issue.errors.full_messages }, status: :unprocessable_entity
-      end
+    if @issue.save
+      render json: @issue.as_json(include: [:status, :tracker, :author, :assigned_to, :attachments, :journals]), status: :ok
     else
-      # Create a new issue based on the provided parameters and the subscription template
-      @issue = Issue.new()
-      @issue.project = @subscription_template.project
-      @issue.tracker = @subscription_template.tracker
-      @issue.subject = params[:subject]
-      @issue.description = params[:description]
-      @issue.is_private = @subscription_template.is_private
-      @issue.status = @subscription_template.issue_status
-      @issue.author = User.current
-      @issue.category = @subscription_template.issue_category
-      @issue.priority = @subscription_template.issue_priority
-      @issue.fixed_version = @subscription_template.version
-
-      # Set the fiware_entity and subscription_template_id attributes of the new issue
-      @issue.fiware_entity = params["entity"]
-      @issue.subscription_template_id = @subscription_template.id
-
-      # If the redmine_gtt plugin is installed and enabled, and geometry data is provided,
-      # try to convert it to an RGeo geometry object
-      if Redmine::Plugin.installed?(:redmine_gtt) && @subscription_template.project.module_enabled?('gtt') && params[:geometry]
-        begin
-          @issue.geom = RedmineGtt::Conversions.to_geom(params[:geometry].to_json)
-        rescue => e
-          logger.warn "Failed to convert geometry data: #{e.message}"
-        end
-      end
-
-      if @issue.save
-        # Respond with the newly created issue and a 201 status code
-        render json: @issue.as_json(include: [:status, :tracker, :author, :assigned_to]), status: :created
-      else
-        # If saving fails, respond with error messages and a 422 status code
-        render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
-      end
+      render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
     end
   end
 
   private
 
   def find_template_and_authorize
-    # Get subscription template from the provided ID
     @subscription_template = SubscriptionTemplate.find_by(id: params[:subscription_template_id])
     unless @subscription_template
       render json: { error: 'Subscription template not found' }, status: :not_found
       return
     end
 
-    # Check if the user has permissions to add issues to the project
     unless User.current.allowed_to?(:add_issues, @subscription_template.project)
       render json: { error: 'Not authorized to create issues' }, status: :forbidden
       return
     end
   end
 
+  def find_or_initialize_issue
+    existing_issue = Issue.where(fiware_entity: params["entity"], subscription_template_id: @subscription_template.id)
+                      .where("created_on >= ?", Time.now - @subscription_template.threshold_create.seconds)
+                      .order(created_on: :desc)
+                      .first
+
+    if existing_issue
+      handle_existing_issue(existing_issue)
+      existing_issue
+    else
+      handle_new_issue
+      @issue
+    end
+  end
+
+  def handle_existing_issue(existing_issue)
+    note = existing_issue.init_journal(User.current, params["notes"])
+
+    if Redmine::Plugin.installed?(:redmine_gtt) && @subscription_template.project.module_enabled?('gtt') && params[:geometry]
+      begin
+        new_geom = RedmineGtt::Conversions.to_geom(params[:geometry].to_json)
+        if new_geom != existing_issue.geom
+          old_geom = existing_issue.geom
+          existing_issue.geom = new_geom
+          note.details.build(property: 'attr', prop_key: 'geom', old_value: old_geom, value: new_geom)
+        end
+      rescue => e
+        logger.warn "Failed to convert geometry data: #{e.message}"
+      end
+    end
+  end
+  def handle_new_issue
+    @issue = Issue.new()
+    @issue.project = @subscription_template.project
+    @issue.tracker = @subscription_template.tracker
+    @issue.subject = params[:subject]
+    @issue.description = params[:description]
+    @issue.is_private = @subscription_template.is_private
+    @issue.status = @subscription_template.issue_status
+    @issue.author = User.current
+    @issue.category = @subscription_template.issue_category
+    @issue.priority = @subscription_template.issue_priority
+    @issue.fixed_version = @subscription_template.version
+    @issue.fiware_entity = params["entity"]
+    @issue.subscription_template_id = @subscription_template.id
+
+    if Redmine::Plugin.installed?(:redmine_gtt) && @subscription_template.project.module_enabled?('gtt') && params[:geometry]
+      begin
+        @issue.geom = RedmineGtt::Conversions.to_geom(params[:geometry].to_json)
+      rescue => e
+        logger.warn "Failed to convert geometry data: #{e.message}"
+      end
+    end
+  end
+
+  def handle_attachments
+    existing_filenames = @issue.attachments.map { |a| a.filename }
+
+    params[:attachments].each do |attachment|
+      uri = URI.parse(attachment['url'])
+      filename = attachment['filename'] || File.basename(uri.path)
+
+      next if existing_filenames.include?(filename)
+
+      begin
+        response = Net::HTTP.get_response(uri)
+
+        if response.is_a?(Net::HTTPSuccess)
+          file = Tempfile.new('attachment')
+          file.binmode
+          file.write(response.body)
+          file.rewind
+
+          description = attachment['description'] || ''
+          content_type = attachment['content_type'] || response.content_type
+
+          uploaded_file = Rack::Multipart::UploadedFile.new(file.path, content_type, true, filename: filename)
+
+          @issue.attachments.build(file: uploaded_file, description: description, author: User.current)
+        else
+          logger.warn "Failed to download file: #{response.message}"
+        end
+      rescue => e
+        logger.warn "Failed to attach file: #{e.message}"
+      end
+    end
+  end
+
   def issue_params
-    # Defines the allowed parameters for an issue
     params.require(:issue).permit(:project, :tracker, :subject, :description, :is_private, :status, :author, :fixed_version, :category, :priority)
   end