image url generation through proper routing helpers

- also includes the API key in the URL

Author: jkraemer

lib/redmine_gtt_print/issue_to_json.rb

@@ -6,6 +6,14 @@ module RedmineGttPrint
   # server.
   #
   class IssueToJson
+    include Rails.application.routes.url_helpers
+
+    # what works in the mailer is good enough for the image URL generation as
+    # well
+    def default_url_options
+      ::Mailer.default_url_options
+    end
+
     def initialize(issue, layout, other_attributes = {})
       @issue = issue
       @layout = layout
@@ -34,7 +42,7 @@ def call
     def image_urls(issue)
       issue.attachments.map do |a|
         if a.image?
-          "#{Setting.protocol}://#{Setting.host_name}/attachments/download/#{a.id}/#{a.filename}"
+          download_named_attachment_url(a, a.filename, key: User.current.api_key)
         end
       end.compact
     end

test/unit/issue_to_json_test.rb

@@ -43,6 +43,7 @@ class IssueToJsonTest < ActiveSupport::TestCase
     assert j = RedmineGttPrint::IssueToJson.(i, 'layout')
     assert h = JSON.parse(j)
     assert_equal i.subject, h['attributes']['subject']
+    assert h['attributes']['image_url_1'].present?
     assert_nil h['attributes']['map']
   end