Skip to content

Commit 78f1e07

Browse files
committed
Fixed tracker/project control issue
Signed-off-by: Ko Nagase <[email protected]>
1 parent 124ca73 commit 78f1e07

File tree

1 file changed

+20
-15
lines changed

1 file changed

+20
-15
lines changed

app/controllers/smash_tags_controller.rb

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ def valid_project_ids
4949
return project_ids
5050
end
5151

52-
def visible_trackers
53-
tracker_ids = Set.new
52+
def valid_tracker_project_ids
53+
tracker_project_ids = {}
5454
valid_project_ids = valid_project_ids()
5555
project_ids = []
5656
if @project.present? and valid_project_ids.include?(@project.id)
@@ -60,10 +60,14 @@ def visible_trackers
6060
end
6161
Project.where(id: project_ids).each {|project|
6262
project.trackers.each {|tracker|
63-
tracker_ids.add(tracker.id)
63+
if tracker_project_ids.has_key?(tracker.id)
64+
tracker_project_ids[tracker.id].append(project.id)
65+
else
66+
tracker_project_ids[tracker.id] = [project.id]
67+
end
6468
}
6569
}
66-
Tracker.where(id: tracker_ids.to_a).sort
70+
return tracker_project_ids
6771
end
6872

6973
# SMASH (Geopaparazzi) form spec: https://www.geopaparazzi.org/geopaparazzi/index.html#_using_form_based_notes
@@ -102,18 +106,19 @@ def build_tags
102106
default_version = @project.default_version.name
103107
end
104108
end
105-
# Projects
106-
projects = []
107-
if @project.blank?
108-
Project.where(id: User.current.visible_project_ids).sort.each {|project|
109-
projects.append({
110-
item: project.name
111-
})
112-
}
113-
end
114109
# Trackers
115-
trackers = visible_trackers()
116-
trackers.sort.each do |tracker|
110+
tracker_project_ids = valid_tracker_project_ids()
111+
Tracker.where(id: tracker_project_ids.keys).sort.each do |tracker|
112+
# Projects
113+
project_ids = tracker_project_ids[tracker.id]
114+
projects = []
115+
if @project.blank? and project_ids.present?
116+
Project.where(id: project_ids).sort.each {|project|
117+
projects.append({
118+
item: project.name
119+
})
120+
}
121+
end
117122
section = {
118123
sectionname: tracker.name,
119124
sectiondescription: tracker.description,

0 commit comments

Comments
 (0)