cleanup when issue is deleted #29

- delete issue_resource_items, issue_supply_items and
  supply_item_journals

Author: jkraemer

lib/redmine_resource_manager/issue_patch.rb

@@ -6,7 +6,7 @@ def self.apply
 
         Issue.class_eval do
 
-          has_many :issue_resource_items
+          has_many :issue_resource_items, dependent: :destroy
           has_many :resource_items, through: :issue_resource_items
 
           accepts_nested_attributes_for :issue_resource_items, allow_destroy: true

lib/redmine_supply/patches/issue_patch.rb

@@ -7,7 +7,8 @@ def self.apply
 
           Issue.class_eval do
 
-            has_many :issue_supply_items
+            has_many :issue_supply_items, dependent: :destroy
+            after_destroy :delete_supply_item_journals
 
             accepts_nested_attributes_for :issue_supply_items
 
@@ -51,6 +52,11 @@ def issue_supply_items_attributes=(attributes = [])
         super attributes
       end
 
+      def delete_supply_item_journals
+        SupplyItemJournal.where(issue_id: id).delete_all
+      end
+      private :delete_supply_item_journals
+
     end
   end
 end

test/unit/issue_supply_item_change_test.rb

@@ -22,6 +22,24 @@ class IssueSupplyItemChangeTest < ActiveSupport::TestCase
   teardown do
   end
 
+  test "should delete changes when issue is deleted" do
+    r = RedmineSupply::SaveSupplyItem.(
+      {name: 'new item', stock: 5}, project: @project
+    )
+    assert i = r.supply_item
+
+    assert_difference 'IssueSupplyItemChange.count' do
+      IssueSupplyItem.create! issue: @issue, supply_item: i, quantity: 1.5
+    end
+
+    assert_difference "IssueSupplyItemChange.count", -1 do
+      assert_difference "IssueSupplyItem.count", -1 do
+        @issue.destroy
+      end
+    end
+  end
+
+
   test 'should record stock change when saved or destroyed' do
     r = RedmineSupply::SaveSupplyItem.(
       {name: 'new item', stock: 5}, project: @project