Delete position default 1 and other customization from Redmine CustomFieldEnumeration model

Author: sanak

app/models/text_block.rb

@@ -5,8 +5,6 @@ class TextBlock < ActiveRecord::Base
 
   validates :name, presence: true
   validate :name_uniqueness
-  validates_numericality_of :position, :only_integer => true
-  before_create :set_position
 
   scope :sorted, ->{ order(Arel.sql('project_id IS NOT NULL, project_id ASC, position ASC')) }
 
@@ -23,14 +21,4 @@ def name_uniqueness
       errors.add :name, I18n.t('model.text_block.name_uniqueness')
     end
   end
-
-  def set_position
-    if project_id.present?
-      max = self.class.where(:project_id => project_id).maximum(:position) || 0
-      self.position = max + 1
-    else
-      max = self.class.where(:project_id => nil).maximum(:position) || 0
-      self.position = max + 1
-    end
-  end
 end

db/migrate/20230325132825_add_position_to_text_blocks.rb

@@ -1,6 +1,6 @@
 class AddPositionToTextBlocks < ActiveRecord::Migration[5.2]
   def change
-    add_column :text_blocks, :position, :integer, :default => 1
+    add_column :text_blocks, :position, :integer
     # # After executing "rake redmine:plugins:migrate", execute the following on "rails console", if keeping the existing positions is important:
     # res = TextBlock.connection.select_all("SELECT id, name, project_id, row_number() over(PARTITION by project_id) AS position FROM #{TextBlock.table_name}")
     # res.rows.each{|row| TextBlock.connection.execute("UPDATE #{TextBlock.table_name} SET position=#{row[3]} WHERE id=#{row[0]}")}