Supporting sortable text_blocks

Author: sanak

app/controllers/text_blocks_controller.rb

@@ -40,9 +40,20 @@ def update
     r = RedmineTextBlocks::SaveTextBlock.(text_block_params,
                                           text_block: @text_block)
     if r.text_block_saved?
-      redirect_to index_path
+      respond_to do |format|
+        format.html {
+          flash[:notice] = l(:notice_successful_update)
+          redirect_to index_path
+        }
+        format.js { head 200 }
+      end
     else
-      render 'edit'
+      respond_to do |format|
+        format.html {
+          render 'edit'
+        }
+        format.js { head 422 }
+      end
     end
   end
 
@@ -69,7 +80,7 @@ def index_path
   end
 
   def text_block_params
-    params[:text_block].permit :name, :text, :issue_status_ids => []
+    params[:text_block].permit :name, :text, :issue_status_ids, :position
   end
 
   def find_text_block
@@ -83,7 +94,7 @@ def find_project_by_project_id
   end
 
   def text_block_scope
-    TextBlock.order(name: :asc).where(project_id: @project&.id)
+    TextBlock.where(project_id: @project&.id).sorted
   end
 
   def get_issue_statuses

app/models/text_block.rb

@@ -1,10 +1,11 @@
 class TextBlock < ActiveRecord::Base
   belongs_to :project
   has_and_belongs_to_many :issue_statuses
+  acts_as_positioned :scope => [:project_id]
 
   validates :name, presence: true
   validate :name_uniqueness
-
+  scope :sorted, ->{ order :position }
 
   private
 

app/views/projects/settings/_text_blocks.html.erb

@@ -2,5 +2,5 @@
   <%= link_to l(:label_text_block_new), new_project_text_block_path(@project), class: 'icon icon-add' %>
 </p>
 
-<%= render partial: 'text_blocks/list', locals: { text_blocks: TextBlock.where(project_id: @project.id) } %>
+<%= render partial: 'text_blocks/list', locals: { text_blocks: TextBlock.where(project_id: @project.id).sorted } %>
 

app/views/text_blocks/_list.html.erb

@@ -32,5 +32,13 @@
         $("table.list.textblocks tbody td.text div").trigger('update.dot');
       }
     });
+    $(function() {
+      $("table.textblocks tbody").positionedItems({
+        scroll: false,
+        sort: function (event, ui) {
+          ui.helper.css({'top': ui.position.top + $(window).scrollTop() + 'px'});
+        },
+      });
+    });
   <% end %>
 <% end %>

app/views/text_blocks/_text_block.html.erb

@@ -6,5 +6,8 @@
       <%= textilizable s %>
     <% end %>
   </div></td>
-  <td><%= delete_link(text_block.project ? project_text_block_path(text_block.project, text_block) : text_block_path(text_block)) %>
+  <td class="buttons">
+    <%= reorder_handle(text_block, url: text_block.project ? project_text_block_path(text_block.project, text_block) : text_block_path(text_block)) %>
+    <%= delete_link(text_block.project ? project_text_block_path(text_block.project, text_block) : text_block_path(text_block)) %>
+  </td>
 </tr>

db/migrate/20230325132825_add_position_to_text_blocks.rb

@@ -1,5 +1,5 @@
 class AddPositionToTextBlocks < ActiveRecord::Migration[5.2]
   def change
-    add_column :text_blocks, :position, :integer
+    add_column :text_blocks, :position, :integer, :default => 1
   end
 end