fix: unable to configure multiple trustify endpoints (#580)

* fix: unable to configure multiple trustify endpoints

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>

* fix: allow comma-separated values for query providers

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>

---------

Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>

Author: ruromero

src/main/java/io/github/guacsec/trustifyda/integration/backend/ExhortIntegration.java

@@ -25,8 +25,8 @@
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.lang.reflect.InvocationTargetException;
 import java.util.AbstractMap;
+import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
@@ -37,6 +37,7 @@
 import org.apache.camel.Exchange;
 import org.apache.camel.ExchangeProperty;
 import org.apache.camel.LoggingLevel;
+import org.apache.camel.builder.AggregationStrategies;
 import org.apache.camel.builder.endpoint.EndpointRouteBuilder;
 import org.apache.camel.component.micrometer.MicrometerConstants;
 import org.apache.camel.component.micrometer.routepolicy.MicrometerRoutePolicyFactory;
@@ -66,7 +67,6 @@
 import jakarta.mail.internet.ContentType;
 import jakarta.mail.internet.ParseException;
 import jakarta.ws.rs.ClientErrorException;
-import jakarta.ws.rs.NotFoundException;
 import jakarta.ws.rs.core.MediaType;
 import jakarta.ws.rs.core.Response;
 import jakarta.ws.rs.core.Response.Status;
@@ -272,9 +272,14 @@ public void configure() {
 
     from(direct("findVulnerabilities"))
       .routeId("findVulnerabilities")
-      .process(this::setProviderConfiguration)
-      .toD("direct:trustifyScan")
-      .process(this::wrapSingleProviderResult)
+      .process(this::setProviders)
+      .setProperty("originalBody", body())
+      .split(exchangeProperty(Constants.PROVIDERS_PROPERTY), AggregationStrategies.beanAllowNull(ProviderAggregationStrategy.class, "aggregate"))
+        .parallelProcessing()
+        .process(this::setProviderConfiguration)
+        .setBody(exchangeProperty("originalBody"))
+        .toD("direct:trustifyScan")
+      .end()
       .transform().method(ProviderAggregationStrategy.class, "toReport");
 
     from(direct("validateToken"))
@@ -357,23 +362,24 @@ private SbomParser getSbomParser(Exchange exchange) {
     return parser;
   }
 
-  private void handleInvocationTargetException(Exchange exchange) {
-    Exception ex = exchange.getException(InvocationTargetException.class);
-    if (ex == null) {
-      return;
+  private void setProviders(Exchange exchange) {
+    List<String> providersQuery = exchange.getProperty(Constants.PROVIDERS_PARAM, List.class);
+    List<String> providers = new ArrayList<>();
+    if (providersQuery != null && !providersQuery.isEmpty()) {
+      for (String provider : providersQuery) {
+        var providerName = provider.trim();
+        providers.add(providerName);
+        if (!vulnerabilityProvider.isProviderEnabled(providerName)) {
+          throw new ClientErrorException(
+              "Provider " + providerName + " is not enabled", Response.Status.BAD_REQUEST);
+        }
+      }
+    }
+    if (providers.isEmpty()) {
+      providers = vulnerabilityProvider.getEnabled();
     }
-    Throwable cause = ex.getCause();
-    if (cause instanceof NotFoundException notFound) {
-      monitoringProcessor.processClientException(exchange);
-      exchange.getIn().setHeader(Exchange.HTTP_RESPONSE_CODE, Status.NOT_FOUND.getStatusCode());
-      exchange.getIn().setHeader(Exchange.CONTENT_TYPE, MediaType.TEXT_PLAIN);
-      exchange.getIn().setBody(notFound.getMessage());
-      exchange
-          .getIn()
-          .setHeader(
-              Constants.EXHORT_REQUEST_ID_HEADER,
-              exchange.getProperty(Constants.EXHORT_REQUEST_ID_HEADER));
-      exchange.setProperty(Exchange.EXCEPTION_HANDLED, true);
+    if (providers != null && !providers.isEmpty()) {
+      exchange.setProperty(Constants.PROVIDERS_PROPERTY, providers);
     }
   }
 
@@ -428,23 +434,9 @@ public Map<String, AnalysisReport> transformBatchAnalysisReportList(
   }
 
   private void setProviderConfiguration(Exchange exchange) {
-    @SuppressWarnings("unchecked")
-    List<String> providers = exchange.getProperty(Constants.PROVIDERS_PARAM, List.class);
-
-    String provider = (providers != null && !providers.isEmpty()) ? providers.get(0) : "trustify";
-
+    var provider = exchange.getIn().getBody(String.class);
     var config = vulnerabilityProvider.getProviderConfig(provider);
     exchange.setProperty(Constants.PROVIDER_NAME_PROPERTY, provider);
     exchange.setProperty(Constants.PROVIDER_CONFIG_PROPERTY, config);
   }
-
-  private void wrapSingleProviderResult(Exchange exchange) {
-    var providerReport =
-        exchange.getIn().getBody(io.github.guacsec.trustifyda.api.v5.ProviderReport.class);
-    if (providerReport != null) {
-      Map<String, io.github.guacsec.trustifyda.api.v5.ProviderReport> result = new HashMap<>();
-      result.put(providerReport.getStatus().getName(), providerReport);
-      exchange.getIn().setBody(result);
-    }
-  }
 }

src/main/java/io/github/guacsec/trustifyda/integration/providers/ProviderAggregationStrategy.java

@@ -48,6 +48,7 @@ public AnalysisReport toReport(
 
     var scanned = new Scanned().direct(tree.directCount()).transitive(tree.transitiveCount());
     scanned.total(scanned.getDirect() + scanned.getTransitive());
+
     return new AnalysisReport().providers(reports).scanned(scanned);
   }
 }

src/main/java/io/github/guacsec/trustifyda/integration/providers/VulnerabilityProvider.java

@@ -17,8 +17,11 @@
 
 package io.github.guacsec.trustifyda.integration.providers;
 
+import java.io.UnsupportedEncodingException;
 import java.net.URISyntaxException;
+import java.net.URLDecoder;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
@@ -183,8 +186,16 @@ private List<String> getProviders(Map<String, Object> props) {
     if (o == null) {
       return null;
     }
-    if (o instanceof String string) {
-      return List.of(string);
+    if (o instanceof String providersQuery) {
+      try {
+        providersQuery = URLDecoder.decode(providersQuery, "UTF-8");
+      } catch (UnsupportedEncodingException e) {
+        throw new ClientErrorException("Unsupported providers: " + providersQuery, 422);
+      }
+      if (providersQuery.contains(",")) {
+        return Arrays.asList(providersQuery.split(","));
+      }
+      return List.of(providersQuery);
     }
     if (o instanceof List<?> list) {
       return (List<String>) list;

src/main/resources/application.properties

@@ -8,7 +8,7 @@ project.build=${timestamp}
 
 
 # Trustify Provider Configuration
-# provider.trustify.host=${TRUSTIFY_HOST:https://trust.rhcloud.com/api/v2/}
+# provider.trustify.host=${TRUSTIFY_HOST:https://trust.rhcloud.com/}
 # provider.trustify.auth.server-url=${TRUSTIFY_AUTH_SERVER_URL}
 # provider.trustify.auth.client-id=${TRUSTIFY_CLIENT_ID}
 # provider.trustify.auth.client-secret=${TRUSTIFY_CLIENT_SECRET}