use unit type for implementing Display on Vec<String> for transaction IDs

Author: Strum355

scenarios/full-20250323.json5

@@ -8,5 +8,5 @@
   "sbom_by_package": "pkg:maven/io.quarkus/quarkus-smallrye-metrics@2.13.8.Final-redhat-00004?type=jar&repository_url=https%3a%2f%2fmaven.repository.redhat.com%2fga%2f",
   "sbom_license_ids": "urn:uuid:0195baea-42e3-7842-a0e3-4c7874263954",
   "analyze_purl": "pkg:rpm/redhat/eap7-activemq-artemis-native@1.0.2-3.redhat_00004.1.el7eap?arch=noarch&epoch=1",
-  "get_recommendations": "pkg:rpm/redhat/eap7-activemq-artemis-native@1.0.2"
+  "get_recommendations": ["pkg:rpm/redhat/eap7-activemq-artemis-native@1.0.2, pkg:maven/io.quarkus/quarkus-smallrye-metrics@2.13.8"]
 }

scenarios/full-20250604.json5

@@ -9,5 +9,5 @@
   "sbom_license_ids": "urn:uuid:01973124-d4ab-7163-b104-331632a21144",
   "analyze_purl": "pkg:rpm/redhat/eap7-activemq-artemis-native@1.0.2-3.redhat_00004.1.el7eap?arch=noarch&epoch=1",
   "get_purl_details": "b00df2ca-df21-5c10-8874-304e9c54e2bd",
-  "get_recommendations": "pkg:rpm/redhat/eap7-activemq-artemis-native@1.0.2"
+  "get_recommendations": ["pkg:rpm/redhat/eap7-activemq-artemis-native@1.0.2, pkg:maven/io.quarkus/quarkus-smallrye-metrics@2.13.8"]
 }

src/restapi.rs

@@ -2,6 +2,8 @@ use goose::goose::{GooseUser, TransactionResult};
 use serde_json::json;
 use urlencoding::encode;
 
+use crate::utils::DisplayVec;
+
 pub async fn list_advisory(user: &mut GooseUser) -> TransactionResult {
     let _response = user.get("/api/v2/advisory").await?;
 
@@ -203,12 +205,15 @@ pub async fn search_purls_by_license(user: &mut GooseUser) -> TransactionResult
     Ok(())
 }
 
-pub async fn get_recommendations(purl: String, user: &mut GooseUser) -> TransactionResult {
+pub async fn get_recommendations(
+    purls: DisplayVec<String>,
+    user: &mut GooseUser,
+) -> TransactionResult {
     let _response = user
         .post_json(
             "/api/v2/purl/recommend",
             &json!({
-             "purls": [purl]
+             "purls": purls
             }),
         )
         .await?;

src/scenario/mod.rs

@@ -1,6 +1,6 @@
 mod purl;
 
-use crate::scenario::purl::CanonicalPurl;
+use crate::{scenario::purl::CanonicalPurl, utils::DisplayVec};
 use anyhow::{Context, anyhow};
 use serde_json::Value;
 use sqlx::{Executor, Row, postgres::PgRow};
@@ -92,8 +92,7 @@ pub(crate) struct Scenario {
     #[serde(with = "required")]
     pub get_purl_details: Option<String>,
 
-    #[serde(with = "required")]
-    pub get_recommendations: Option<String>,
+    pub get_recommendations: Option<DisplayVec<String>>,
 }
 
 impl Scenario {
@@ -164,6 +163,12 @@ impl Loader {
             .ok_or_else(|| anyhow!("nothing found"))
     }
 
+    async fn find_rows(&self, sql: &str) -> anyhow::Result<Vec<PgRow>> {
+        let mut db = crate::db::connect(&self.db).await?;
+
+        Ok(db.fetch_all(sql).await?)
+    }
+
     /// get the SHA256 of the largest SBOM (by number of packages)
     pub async fn large_sbom(&self) -> anyhow::Result<(String, String)> {
         // get the largest SBOM in the database
@@ -283,23 +288,27 @@ LIMIT 1;
     }
 
     // A purl whose version matches redhat-[0-9]+$ regex
-    pub async fn purl_with_recommendations(&self) -> anyhow::Result<String> {
-        self.find_row(
+    pub async fn purl_with_recommendations(&self) -> anyhow::Result<DisplayVec<String>> {
+        self.find_rows(
             r#"
 SELECT
     purl AS result
 FROM
     qualified_purl
 WHERE
     purl->>'version' ~ 'redhat-[0-9]+$'
-LIMIT 1;
+LIMIT 10;
 "#,
         )
         .await
-        .and_then(|row| {
-            let value: Value = row.try_get("result")?;
-            let purl: CanonicalPurl = serde_json::from_value(value)?;
-            Ok::<String, anyhow::Error>(purl.to_string())
+        .and_then(|rows| {
+            let mut result = vec![];
+            for row in rows {
+                let value: Value = row.try_get("result")?;
+                let purl: CanonicalPurl = serde_json::from_value(value)?;
+                result.push(purl.to_string());
+            }
+            Ok(DisplayVec(result))
         })
     }
 }

src/utils.rs

@@ -13,6 +13,16 @@ pub fn truncate_middle(s: impl Display, max_len: usize) -> String {
     }
 }
 
+#[derive(Clone, Debug, PartialEq, Eq, serde::Deserialize, serde::Serialize)]
+pub struct DisplayVec<T>(pub Vec<T>);
+
+impl<T: std::fmt::Display> std::fmt::Display for DisplayVec<T> {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        let strs: Vec<String> = self.0.iter().map(|item| item.to_string()).collect();
+        write!(f, "{}", strs.join(","))
+    }
+}
+
 #[cfg(test)]
 mod test {
     use super::*;