build: saves ~11 seconds build time

[helio-frota]

Please let me know with 👍 or 👎 or PR review rejection/approval if this worth to have a bit verbose Cargo.toml to save ~15 seconds during build.

More details you can see here: #1323 (comment)

[helio-frota]

Update: now 170.3s (2m 50.3s) ~11 seconds got tests broken , interestingly the build pass and we have a runtime error in tests...

[JimFuller-RedHat]

I would first fix tests and whatever runtime error (maybe good to raise issue for each as well).

[ctron]

I'm not sure saving 11 seconds build time really is that important, adding that extra complexity of maintaining all those feature flags. On the other side, it may be more for a --release build. And it may have a positive impact on the release binary? I think those things should be checked as well.

[helio-frota]

thanks for the feedback folks

I would first fix tests and whatever runtime error (maybe good to raise issue for each as well).

yeah that was fixed yesterday. It was caused by:

- git2 = { version = "0.20.0", default-features = false, features = ["ssh"] }
+ git2 = { version = "0.20.0", features = ["ssh"] }

probably related to the missing https feature and the runtime error in tests fixed yesterday removing default-features = false

I'm not sure saving 11 seconds build time really is that important, adding that extra complexity of maintaining all those feature flags.

yeah that's why I 👎

On the other side, it may be more for a --release build. And it may have a positive impact on the release binary? I think those things should be checked as well.

We have the same result without --release

Before:

After:

@JimFuller-RedHat @ctron let's close the the PR and the issue then?

[ctron]

Yea, if the size of the release binary doesn't show any significant different either, let's close it.

[helio-frota]

ok closing 👍

➜  trustify git:(issue-1323) ls -sh target/release/trustd
114M target/release/trustd*
➜  trustify git:(issue-1323) cargo build --no-default-features --release