File tree Expand file tree Collapse file tree 1 file changed +14
-3
lines changed
docs/architecture/proposals Expand file tree Collapse file tree 1 file changed +14
-3
lines changed Original file line number Diff line number Diff line change @@ -22,17 +22,27 @@ await insertAds();
2222await updateAds ();
2323```
2424
25- ### Initialise step
25+ ### Initialise
2626
2727The consented-advertising file contains lots of information about init scripts that is hard to follow.
2828
29+ This should include what is currently known as ` commercialFeatures ` and should change ` commercialFeatures ` from a class into a JSON object or similar.
30+
2931Open questions:
3032
3133- How do we know what the correct order/priority is for these init scripts?
3234- What is comscore? Why does it need to run first? Why does it run on ad free?
3335-
3436
35- ### Coding Standards
37+ ### insertAds
38+
39+ TODO
40+
41+ ### updateAds
42+
43+ TODO
44+
45+ ## Coding Standards
3646
3747We propose establishing the following coding standards:
3848
@@ -50,4 +60,5 @@ We propose establishing the following coding standards:
5060 import { initGoogleTag } from ' ../googletag' ;
5161 ```
5262
53- -
63+ - ** Use pure functions ** and avoid using classes where possible . The commercial bundle does not really need to use classes
64+ When side effects are necessary (like DOM manipulation ), clearly note this in a JSDoc comment . Ideally we would include an eslint rule to prevent functions with side effects from being added without a suitable explanation for why this is happening
You can’t perform that action at this time.
0 commit comments